From: Mel Gorman <mel@csn.ul.ie>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH 2/5] Breakout page_order() to internal.h to avoid special knowledge of the buddy allocator
Date: Fri, 25 May 2007 10:02:07 +0100 (IST) [thread overview]
Message-ID: <Pine.LNX.4.64.0705251001100.12364@skynet.skynet.ie> (raw)
In-Reply-To: <Pine.LNX.4.64.0705241207260.30227@schroedinger.engr.sgi.com>
On Thu, 24 May 2007, Christoph Lameter wrote:
> On Thu, 24 May 2007, Mel Gorman wrote:
>
>> The statistics patch later needs to know what order a free page is on the
>> free lists. Rather than having special knowledge of page_private() when
>> PageBuddy() is set, this patch places out page_order() in internal.h and
>> adds a VM_BUG_ON to catch using it on non-PageBuddy pages.
>
> Ok but I think in the future we need to have some way to generally handle
> pages of higher order be they free or not. Maybe generalize the way we
> handle compound pages as done in the large blocksize patchset?
>
Ordinarily I would consider compound pages to be the general way
high-order pages are handled - at least while they are allocated. I'll
take a closer look again at what the blocksize patchset is doing.
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
>
--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-05-25 9:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-24 19:05 [PATCH 0/5] Arbitrary grouping and statistics for grouping pages by mobility Mel Gorman
2007-05-24 19:05 ` [PATCH 1/5] Fix calculation in move_freepages_block for counting pages Mel Gorman
2007-05-24 19:07 ` Christoph Lameter
2007-05-24 19:05 ` [PATCH 2/5] Breakout page_order() to internal.h to avoid special knowledge of the buddy allocator Mel Gorman
2007-05-24 19:08 ` Christoph Lameter
2007-05-25 9:02 ` Mel Gorman [this message]
2007-05-24 19:06 ` [PATCH 3/5] Do not depend on MAX_ORDER when grouping pages by mobility Mel Gorman
2007-05-24 19:10 ` Christoph Lameter
2007-05-24 19:06 ` [PATCH 4/5] Print out statistics in relation to fragmentation avoidance to /proc/pagetypeinfo Mel Gorman
2007-05-24 19:11 ` Christoph Lameter
2007-05-24 19:06 ` [PATCH 5/5] Print out PAGE_OWNER statistics in relation to fragmentation avoidance Mel Gorman
2007-05-24 19:11 ` Christoph Lameter
2007-05-25 9:03 ` Mel Gorman
2007-05-25 9:21 [PATCH 0/5] Arbitrary grouping and statistics for grouping pages by mobility Mel Gorman
2007-05-25 9:22 ` [PATCH 2/5] Breakout page_order() to internal.h to avoid special knowledge of the buddy allocator Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0705251001100.12364@skynet.skynet.ie \
--to=mel@csn.ul.ie \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox