From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 23 May 2007 15:48:18 -0700 (PDT) From: Christoph Lameter Subject: Re: [patch 1/3] slob: rework freelist handling In-Reply-To: <20070523224206.GN11115@waste.org> Message-ID: References: <20070523061702.GA9449@wotan.suse.de> <20070523071200.GB9449@wotan.suse.de> <20070523183224.GD11115@waste.org> <20070523195824.GF11115@waste.org> <20070523210612.GI11115@waste.org> <20070523224206.GN11115@waste.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Matt Mackall Cc: Nick Piggin , Andrew Morton , Linux Memory Management List List-ID: On Wed, 23 May 2007, Matt Mackall wrote: > On Wed, May 23, 2007 at 03:26:05PM -0700, Christoph Lameter wrote: > > On Wed, 23 May 2007, Matt Mackall wrote: > > > > > On Wed, May 23, 2007 at 01:02:53PM -0700, Christoph Lameter wrote: > > > > On Wed, 23 May 2007, Matt Mackall wrote: > > > > > > > > > Meanwhile this function is only called from swsusp.c. > > > > > > > > NR_SLAB_UNRECLAIMABLE is also used in __vm_enough_memory and > > > > in zone reclaim (well ok thats only NUMA). > > > > > > It's NR_SLAB_RECLAIMABLE in __vm_enough_memory. And that is always > > > zero with SLOB. There aren't any reclaimable slab pages. > > > > All dentries and inodes are reclaimable via the shrinkers in vmscan.c. So > > you are saying that SLOB does not allow dentry and inode reclaim? > > No. I've already pointed out the EXACT CALL CHAIN that leads to dentry > reclaim. And it's independent of NR_SLAB_RECLAIMABLE and independent > of allocator. So we have an allocator which is not following the rules... You are arguing that dysfunctional behavior of SLOB does not have bad effects. 1. We have allocated reclaimable objects via SLOB (dentry & inodes) 2. We can reclaim them 3. The allocator lies about it telling the VM that there is nothing reclaimable because NR_SLAB_UNRECLAIMABLE is always 0. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org