From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 22 May 2007 22:06:56 -0700 (PDT) From: Christoph Lameter Subject: Re: [patch 1/3] slob: rework freelist handling In-Reply-To: <20070523050333.GB29045@wotan.suse.de> Message-ID: References: <20070522073910.GD17051@wotan.suse.de> <20070522145345.GN11115@waste.org> <20070523030637.GC9255@wotan.suse.de> <20070523045938.GA29045@wotan.suse.de> <20070523050333.GB29045@wotan.suse.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: Matt Mackall , Andrew Morton , Linux Memory Management List List-ID: On Wed, 23 May 2007, Nick Piggin wrote: > Is there a patch for it? Turning on CONFIG_SLUB_DEBUG doesn't seem like > a good idea when trying to make a comparison. CONFIG_SLUB_DEBUG does not turn on debugging and should be on always. This is not SLAB. Here is the fix: --- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: slub/mm/slub.c =================================================================== --- slub.orig/mm/slub.c 2007-05-21 11:21:36.000000000 -0700 +++ slub/mm/slub.c 2007-05-21 11:21:49.000000000 -0700 @@ -1943,7 +1943,6 @@ static int calculate_sizes(struct kmem_c */ s->inuse = size; -#ifdef CONFIG_SLUB_DEBUG if (((flags & (SLAB_DESTROY_BY_RCU | SLAB_POISON)) || s->ctor)) { /* @@ -1958,6 +1957,7 @@ static int calculate_sizes(struct kmem_c size += sizeof(void *); } +#ifdef CONFIG_SLUB_DEBUG if (flags & SLAB_STORE_USER) /* * Need to store information about allocs and frees after -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org