From: Christoph Lameter <clameter@sgi.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, hugh@veritas.com, Mel Gorman <mel@csn.ul.ie>
Subject: Re: Fix page allocation flags in grow_dev_page()
Date: Wed, 16 May 2007 13:42:56 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0705161342110.11234@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20070516133416.9d730d08.akpm@linux-foundation.org>
On Wed, 16 May 2007, Andrew Morton wrote:
> erk. When I fixed this up against Mel's stuff I ended up with:
>
> page = find_or_create_page(inode->i_mapping, index,
> (mapping_gfp_mask(inode->i_mapping) & ~__GFP_FS) |
> __GFP_RECLAIMABLE);
>
> static inline int allocflags_to_migratetype(gfp_t gfp_flags)
> {
> WARN_ON((gfp_flags & GFP_MOVABLE_MASK) == GFP_MOVABLE_MASK);
>
> so I assume that mapping_gfp_mask() already had __GFP_MOVABLE set.
>
>
> So... which is it to be?
>
Yup. This was already reported during my review to Mel.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-05-16 20:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 4:12 Christoph Lameter
2007-05-16 20:34 ` Andrew Morton
2007-05-16 20:42 ` Christoph Lameter [this message]
2007-05-16 21:48 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0705161342110.11234@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox