From: Christoph Lameter <clameter@sgi.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: SLUB: Reduce antifrag max order
Date: Tue, 8 May 2007 09:12:58 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0705080912080.8801@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0705081411440.20563@skynet.skynet.ie>
On Tue, 8 May 2007, Mel Gorman wrote:
> Anti-frag still depends on reclaim to take place and I imagine you have not
> altered min_free_kbytes to keep pages free. Also, I don't think kswapd is
> currently making any effort to keep blocks free at a known desired order
> although I'm cc'ing Andy Whitcroft to confirm. As the kernel gives up easily
> when order > PAGE_ALLOC_COSTLY_ORDER, prehaps you should be using
> PAGE_ALLOC_COSTLY_ORDER instead of DEFAULT_ANTIFRAG_MAX_ORDER for SLUB.
Ok. So we need this one.
Signed-off-by: Christoph Lameter <clameter@sgi.com>
---
mm/slub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: slub/mm/slub.c
===================================================================
--- slub.orig/mm/slub.c 2007-05-08 09:10:54.000000000 -0700
+++ slub/mm/slub.c 2007-05-08 09:11:15.000000000 -0700
@@ -153,7 +153,7 @@ static inline void ClearSlabDebug(struct
* If antifragmentation methods are in effect then increase the
* slab sizes to increase performance
*/
-#define DEFAULT_ANTIFRAG_MAX_ORDER 3
+#define DEFAULT_ANTIFRAG_MAX_ORDER PAGE_ALLOC_COSTLY_ORDER
#define DEFAULT_ANTIFRAG_MIN_OBJECTS 16
/*
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-05-08 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-05 16:26 Christoph Lameter
2007-05-08 13:15 ` Mel Gorman
2007-05-08 16:12 ` Christoph Lameter [this message]
2007-05-09 18:25 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0705080912080.8801@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox