From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 30 Apr 2007 21:33:56 +0100 (IST) From: Mel Gorman Subject: Re: [PATCH 4/4] Add __GFP_TEMPORARY to identify allocations that are short-lived In-Reply-To: Message-ID: References: <20070430185524.7142.56162.sendpatchset@skynet.skynet.ie> <20070430185644.7142.89206.sendpatchset@skynet.skynet.ie> <20070430194427.GA8205@skynet.ie> <20070430201147.GB8205@skynet.ie> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Linux Memory Management List List-ID: On Mon, 30 Apr 2007, Christoph Lameter wrote: > On Mon, 30 Apr 2007, Mel Gorman wrote: > >>>>>> #ifdef CONFIG_JBD_DEBUG >>>>>> atomic_inc(&nr_journal_heads); >>>>>> #endif >>>>>> - ret = kmem_cache_alloc(journal_head_cache, >>>>>> - set_migrateflags(GFP_NOFS, __GFP_RECLAIMABLE)); >>>>>> + ret = kmem_cache_alloc(journal_head_cache, GFP_NOFS); >>>>>> if (ret == 0) { >>>>> >>>>> This chunk belongs into the earlier patch. >>>>> >>>> >>>> Why? kmem_cache_create() is changed here in this patch to use SLAB_TEMPORARY >>>> which is not defined until this patch. >>> >>> I do not see a SLAB_TEMPORARY here. >> >> Here are the relevant portions of the fourth patch. > > Ahh. Ok. > I'll assume that means they are currently located in the right patch. I've queued up more tests with the revised patchset. Assuming they pass, I'll push them towards Andrew and start on the grouping-at-orders-other-than-MAX_ORDER patch. Thanks. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org