From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 30 Apr 2007 12:52:19 -0700 (PDT) From: Christoph Lameter Subject: Re: [PATCH 4/4] Add __GFP_TEMPORARY to identify allocations that are short-lived In-Reply-To: <20070430194427.GA8205@skynet.ie> Message-ID: References: <20070430185524.7142.56162.sendpatchset@skynet.skynet.ie> <20070430185644.7142.89206.sendpatchset@skynet.skynet.ie> <20070430194427.GA8205@skynet.ie> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Mel Gorman Cc: linux-mm@kvack.org List-ID: On Mon, 30 Apr 2007, Mel Gorman wrote: > > White space damage. > > > > Fixed. to be ( GFP_TEMPORARY ) although that itself looks odd. Needs to be (GFP_TEMPORARY) > >> --- linux-2.6.21-rc7-mm2-002_account_reclaimable/fs/jbd/journal.c 2007-04-27 22:04:33.000000000 +0100 > >> +++ linux-2.6.21-rc7-mm2-003_temporary/fs/jbd/journal.c 2007-04-30 16:38:41.000000000 +0100 > >> @@ -1739,8 +1739,7 @@ static struct journal_head *journal_allo > >> #ifdef CONFIG_JBD_DEBUG > >> atomic_inc(&nr_journal_heads); > >> #endif > >> - ret = kmem_cache_alloc(journal_head_cache, > >> - set_migrateflags(GFP_NOFS, __GFP_RECLAIMABLE)); > >> + ret = kmem_cache_alloc(journal_head_cache, GFP_NOFS); > >> if (ret == 0) { > > > > This chunk belongs into the earlier patch. > > > > Why? kmem_cache_create() is changed here in this patch to use SLAB_TEMPORARY > which is not defined until this patch. I do not see a SLAB_TEMPORARY here. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org