From: Christoph Lameter <clameter@sgi.com>
To: Mel Gorman <mel@skynet.ie>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH 4/4] Add __GFP_TEMPORARY to identify allocations that are short-lived
Date: Mon, 30 Apr 2007 12:52:19 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0704301250580.8361@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20070430194427.GA8205@skynet.ie>
On Mon, 30 Apr 2007, Mel Gorman wrote:
> > White space damage.
> >
>
> Fixed. to be ( GFP_TEMPORARY ) although that itself looks odd.
Needs to be (GFP_TEMPORARY)
> >> --- linux-2.6.21-rc7-mm2-002_account_reclaimable/fs/jbd/journal.c 2007-04-27 22:04:33.000000000 +0100
> >> +++ linux-2.6.21-rc7-mm2-003_temporary/fs/jbd/journal.c 2007-04-30 16:38:41.000000000 +0100
> >> @@ -1739,8 +1739,7 @@ static struct journal_head *journal_allo
> >> #ifdef CONFIG_JBD_DEBUG
> >> atomic_inc(&nr_journal_heads);
> >> #endif
> >> - ret = kmem_cache_alloc(journal_head_cache,
> >> - set_migrateflags(GFP_NOFS, __GFP_RECLAIMABLE));
> >> + ret = kmem_cache_alloc(journal_head_cache, GFP_NOFS);
> >> if (ret == 0) {
> >
> > This chunk belongs into the earlier patch.
> >
>
> Why? kmem_cache_create() is changed here in this patch to use SLAB_TEMPORARY
> which is not defined until this patch.
I do not see a SLAB_TEMPORARY here.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-04-30 19:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-30 18:55 [PATCH 0/4] Clarify GFP flag usage when grouping pages by mobility Mel Gorman
2007-04-30 18:55 ` [PATCH 1/4] Fix alloc_zeroed_user_highpage on m68knommu Mel Gorman
2007-04-30 18:56 ` [PATCH 2/4] Remove alloc_zeroed_user_highpage() Mel Gorman
2007-04-30 18:56 ` [PATCH 3/4] Use SLAB_ACCOUNT_RECLAIM to determine when __GFP_RECLAIMABLE should be used Mel Gorman
2007-04-30 19:02 ` Christoph Lameter
2007-04-30 18:56 ` [PATCH 4/4] Add __GFP_TEMPORARY to identify allocations that are short-lived Mel Gorman
2007-04-30 19:08 ` Christoph Lameter
2007-04-30 19:44 ` Mel Gorman
2007-04-30 19:52 ` Christoph Lameter [this message]
2007-04-30 20:11 ` Mel Gorman
2007-04-30 20:14 ` Christoph Lameter
2007-04-30 20:33 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0704301250580.8361@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=linux-mm@kvack.org \
--cc=mel@skynet.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox