Re: 2.6.21-rc7-mm1 on test.kernel.org

[Christoph Lameter <clameter@sgi.com>]

On Tue, 24 Apr 2007, Andrew Morton wrote:

> > gcc version 3.3.3 -- generates those link failures
> > gcc version 4.1.0 -- doesn't generate this error
> 
> My power box is 3.4.4 and it doesn't do that either.  I guess it's just a
> gcc buglet.
> 
> Poor Christoph ;)
> 
> I wonder why slab doesn't hit that problem.
> 
> I wonder whether slub should use kmalloc-sizes.h.

Builds fine here with gcc 3.3 on x86_64. Maybe a problem with the arch 
specific backend? Maybe it does not inline by default?

Does forcing inlining fix the problem?

Index: linux-2.6.21-rc7/include/linux/slub_def.h
===================================================================
--- linux-2.6.21-rc7.orig/include/linux/slub_def.h	2007-04-24 23:50:27.000000000 -0700
+++ linux-2.6.21-rc7/include/linux/slub_def.h	2007-04-24 23:51:08.000000000 -0700
@@ -84,7 +84,7 @@ extern struct kmem_cache kmalloc_caches[
  * Sorry that the following has to be that ugly but some versions of GCC
  * have trouble with constant propagation and loops.
  */
-static inline int kmalloc_index(int size)
+static __always_inline int kmalloc_index(int size)
 {
 	if (size == 0)
 		return 0;
 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>