From: Christoph Lameter <clameter@sgi.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, David Miller <davem@davemloft.net>
Subject: slab allocators: Remove multiple alignment specifications.
Date: Fri, 20 Apr 2007 22:12:52 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0704202210060.17036@schroedinger.engr.sgi.com> (raw)
It is not necessary to tell the slab allocators to align to a cacheline
if an explicit alignment was already specified. It is rather confusing
to specify multiple alignments.
Make sure that the call sites only use one form of alignment.
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Index: linux-2.6.21-rc6/arch/powerpc/mm/hugetlbpage.c
===================================================================
--- linux-2.6.21-rc6.orig/arch/powerpc/mm/hugetlbpage.c 2007-04-20 19:25:14.000000000 -0700
+++ linux-2.6.21-rc6/arch/powerpc/mm/hugetlbpage.c 2007-04-20 19:25:40.000000000 -0700
@@ -1063,7 +1063,7 @@ static int __init hugetlbpage_init(void)
huge_pgtable_cache = kmem_cache_create("hugepte_cache",
HUGEPTE_TABLE_SIZE,
HUGEPTE_TABLE_SIZE,
- SLAB_HWCACHE_ALIGN,
+ 0,
zero_ctor, NULL);
if (! huge_pgtable_cache)
panic("hugetlbpage_init(): could not create hugepte cache\n");
Index: linux-2.6.21-rc6/arch/powerpc/mm/init_64.c
===================================================================
--- linux-2.6.21-rc6.orig/arch/powerpc/mm/init_64.c 2007-04-20 19:25:14.000000000 -0700
+++ linux-2.6.21-rc6/arch/powerpc/mm/init_64.c 2007-04-20 19:25:40.000000000 -0700
@@ -183,7 +183,7 @@ void pgtable_cache_init(void)
"for size: %08x...\n", name, i, size);
pgtable_cache[i] = kmem_cache_create(name,
size, size,
- SLAB_HWCACHE_ALIGN,
+ 0,
zero_ctor,
NULL);
if (! pgtable_cache[i])
Index: linux-2.6.21-rc6/arch/sparc64/mm/init.c
===================================================================
--- linux-2.6.21-rc6.orig/arch/sparc64/mm/init.c 2007-04-20 19:25:14.000000000 -0700
+++ linux-2.6.21-rc6/arch/sparc64/mm/init.c 2007-04-20 19:25:40.000000000 -0700
@@ -191,7 +191,7 @@ void pgtable_cache_init(void)
{
pgtable_cache = kmem_cache_create("pgtable_cache",
PAGE_SIZE, PAGE_SIZE,
- SLAB_HWCACHE_ALIGN,
+ 0,
zero_ctor,
NULL);
if (!pgtable_cache) {
Index: linux-2.6.21-rc6/arch/sparc64/mm/tsb.c
===================================================================
--- linux-2.6.21-rc6.orig/arch/sparc64/mm/tsb.c 2007-04-20 19:25:14.000000000 -0700
+++ linux-2.6.21-rc6/arch/sparc64/mm/tsb.c 2007-04-20 19:25:40.000000000 -0700
@@ -262,7 +262,7 @@ void __init tsb_cache_init(void)
tsb_caches[i] = kmem_cache_create(name,
size, size,
- SLAB_HWCACHE_ALIGN,
+ 0,
NULL, NULL);
if (!tsb_caches[i]) {
prom_printf("Could not create %s cache\n", name);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2007-04-21 5:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-21 5:12 Christoph Lameter [this message]
2007-04-21 5:37 ` Andrew Morton
2007-04-21 5:44 ` Christoph Lameter
2007-04-21 6:11 ` Andrew Morton
2007-04-21 6:32 ` Christoph Lameter
2007-04-21 6:35 ` Christoph Lameter
2007-04-21 6:38 ` Christoph Lameter
2007-04-21 6:51 ` Andrew Morton
2007-04-21 6:45 ` Andrew Morton
2007-04-21 15:49 ` Christoph Lameter
2007-04-23 15:44 ` Robin Holt
2007-04-23 15:53 ` Christoph Lameter
2007-04-23 15:56 ` Robin Holt
2007-04-26 20:00 ` Dean Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0704202210060.17036@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox