From: Christoph Lameter <clameter@sgi.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org
Subject: [PATCH] sprint_symbol should return length of string like sprintf
Date: Thu, 22 Mar 2007 22:35:00 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0703222234320.7918@schroedinger.engr.sgi.com> (raw)
[PATCH] sprint_symbol should return length of string like sprintf
Make sprint_symbol return the length of the symbol
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Index: linux-2.6.21-rc4-mm1/include/linux/kallsyms.h
===================================================================
--- linux-2.6.21-rc4-mm1.orig/include/linux/kallsyms.h 2007-03-22 11:35:28.000000000 -0700
+++ linux-2.6.21-rc4-mm1/include/linux/kallsyms.h 2007-03-22 11:37:19.000000000 -0700
@@ -25,7 +25,7 @@ const char *kallsyms_lookup(unsigned lon
char **modname, char *namebuf);
/* Look up a kernel symbol and return it in a text buffer. */
-extern void sprint_symbol(char *buffer, unsigned long address);
+extern int sprint_symbol(char *buffer, unsigned long address);
/* Look up a kernel symbol and print it to the kernel messages. */
extern void __print_symbol(const char *fmt, unsigned long address);
Index: linux-2.6.21-rc4-mm1/kernel/kallsyms.c
===================================================================
--- linux-2.6.21-rc4-mm1.orig/kernel/kallsyms.c 2007-03-22 11:35:28.000000000 -0700
+++ linux-2.6.21-rc4-mm1/kernel/kallsyms.c 2007-03-22 11:37:19.000000000 -0700
@@ -268,7 +268,7 @@ const char *kallsyms_lookup(unsigned lon
}
/* Look up a kernel symbol and return it in a text buffer. */
-void sprint_symbol(char *buffer, unsigned long address)
+int sprint_symbol(char *buffer, unsigned long address)
{
char *modname;
const char *name;
@@ -277,13 +277,13 @@ void sprint_symbol(char *buffer, unsigne
name = kallsyms_lookup(address, &size, &offset, &modname, namebuf);
if (!name)
- sprintf(buffer, "0x%lx", address);
+ return sprintf(buffer, "0x%lx", address);
else {
if (modname)
- sprintf(buffer, "%s+%#lx/%#lx [%s]", name, offset,
+ return sprintf(buffer, "%s+%#lx/%#lx [%s]", name, offset,
size, modname);
else
- sprintf(buffer, "%s+%#lx/%#lx", name, offset, size);
+ return sprintf(buffer, "%s+%#lx/%#lx", name, offset, size);
}
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
reply other threads:[~2007-03-23 5:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0703222234320.7918@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox