linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mel Gorman <mel@csn.ul.ie>
To: Bill Irwin <bill.irwin@oracle.com>
Cc: akpm@linux-foundation.org, npiggin@suse.de,
	clameter@engr.sgi.com, mingo@elte.hu,
	Joel Schopp <jschopp@austin.ibm.com>,
	arjan@infradead.org, torvalds@osdl.org, mbligh@mbligh.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: The performance and behaviour of the anti-fragmentation related patches
Date: Fri, 2 Mar 2007 10:38:33 +0000 (GMT)	[thread overview]
Message-ID: <Pine.LNX.4.64.0703021018070.32022@skynet.skynet.ie> (raw)
In-Reply-To: <20070302015235.GG10643@holomorphy.com>

On Thu, 1 Mar 2007, Bill Irwin wrote:

> On Thu, Mar 01, 2007 at 10:12:50AM +0000, Mel Gorman wrote:
>> These are figures based on kernels patches with Andy Whitcrofts reclaim
>> patches. You will see that the zone-based kernel is getting success rates
>> closer to 40% as one would expect although there is still something amiss.
>
> Yes, combining the two should do at least as well as either in
> isolation. Are there videos of each of the two in isolation?

Yes. Towards the end of the mail, I give links to all of the images like 
this for example;

elm3b14-vanilla       http://www.skynet.ie/~mel/anti-frag/2007-02-28/elm3b14-vanilla.avi
elm3b14-list-based    http://www.skynet.ie/~mel/anti-frag/2007-02-28/elm3b14-listbased.avi
elm3b14-zone-based    http://www.skynet.ie/~mel/anti-frag/2007-02-28/elm3b14-zonebased.avi
elm3b14-combined      http://www.skynet.ie/~mel/anti-frag/2007-02-28/elm3b14-combined.avi

In the zone-based figures, there are pages there that could be reclaimed, 
but are ignored by page reclaim because watermarks are satisified.

> Maybe that
> would give someone insight into what's happening.
>
>
> On Thu, Mar 01, 2007 at 10:12:50AM +0000, Mel Gorman wrote:
>> Kernbench Total CPU Time
>
> Oh dear. How do the other benchmarks look?
>

What other figures would you like to see and I'll generate them. Often 
kernbench is all people look for for this type of thing.

"Oh dear" implies you think the figures are bad. But on ppc64 and x86_64 
at least, the total CPU times are slightly lower with both 
anti-fragmentation patches - that's not bad. On NUMA-Q (which no one uses 
any more or is even sold), it's very marginally slower.

These are the AIM9 figures I have

AIM9 Results
                                       Vanilla Kernel   List-base Kernel  Zone-base Kernel  Combined Kernel
Machine       Arch      Test              Seconds           Seconds           Seconds          Seconds
-------     ---------  ------         --------------   ----------------  ----------------  ---------------
elm3b14     x86-numaq   page_test      115108.30           112955.68             109773.37            108073.65 
elm3b14     x86-numaq   brk_test       520593.14           494251.92             496801.07            488141.24 
elm3b14     x86-numaq   fork_test      2007.99             2005.66               2011.00              1986.35 
elm3b14     x86-numaq   exec_test      57.11               57.15                 57.27                57.01 
elm3b245    x86_64      page_test      220490.00           218166.67             224371.67            224164.31 
elm3b245    x86_64      brk_test       2178186.97          2337110.48            3025495.75           2445733.33 
elm3b245    x86_64      fork_test      4854.19             4957.51               4900.03              5001.67 
elm3b245    x86_64      exec_test      194.55              196.30                195.55               195.90 
gekko-lp1   ppc64       page_test      300368.27           310651.56             300673.33            308720.00 
gekko-lp1   ppc64       brk_test       1328895.18          1403448.85            1431489.50           1408263.91 
gekko-lp1   ppc64       fork_test      3374.42             3395.00               3367.77              3396.64 
gekko-lp1   ppc64       exec_test      152.87              153.12                151.92               153.39 
gekko-lp4   ppc64       page_test      291643.06           306906.67             294872.52            303796.03 
gekko-lp4   ppc64       brk_test       1322946.18          1366572.24            1378470.25           1403116.15 
gekko-lp4   ppc64       fork_test      3326.11             3335.00               3315.56              3333.33 
gekko-lp4   ppc64       exec_test      149.01              149.90                149.48               149.87

Many of these are showing performance improvements as well, not 
regressions.

>
> On Thu, Mar 01, 2007 at 10:12:50AM +0000, Mel Gorman wrote:
>> The patches go a long way to making sure that high-order allocations work
>> and particularly that the hugepage pool can be resized once the system has
>> been running. With the clustering of high-order atomic allocations, I have
>> some confidence that allocating contiguous jumbo frames will work even with
>> loads performing lots of IO. I think the videos show how the patches actually
>> work in the clearest possible manner.
>> I am of the opinion that both approaches have their advantages and
>> disadvantages. Given a choice between the two, I prefer list-based
>> because of it's flexibility and it should also help high-order kernel
>> allocations. However, by applying both, the disadvantages of list-based are
>> covered and there still appears to be no performance loss as a result. Hence,
>> I'd like to see both merged.  Any opinion on merging these patches into -mm
>> for wider testing?
>
> Exhibiting a workload where the list patch breaks down and the zone
> patch rescues it might help if it's felt that the combination isn't as
> good as lists in isolation. I'm sure one can be dredged up somewhere.

I can't think of a workload that totally makes a mess out of list-based. 
However, list-based makes no guarantees on availability. If a system 
administrator knows they need between 10,000 and 100,000 huge pages and 
doesn't want to waste memory pinning too many huge pages at boot-time, the 
zone-based mechanism would be what he wanted.

> Either that or someone will eventually spot why the combination doesn't
> get as many available maximally contiguous regions as the list patch.
> By and large I'm happy to see anything go in that inches hugetlbfs
> closer to a backward compatibility wrapper over ramfs.
>

Good to hear

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2007-03-02 10:38 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-01 10:12 Mel Gorman
2007-03-02  0:09 ` Andrew Morton
2007-03-02  0:44   ` Linus Torvalds
2007-03-02  1:52     ` Balbir Singh
2007-03-02  3:44       ` Linus Torvalds
2007-03-02  3:59         ` Andrew Morton
2007-03-02  5:11           ` Linus Torvalds
2007-03-02  5:50             ` KAMEZAWA Hiroyuki
2007-03-02  6:15               ` Paul Mundt
2007-03-02 17:01                 ` Mel Gorman
2007-03-02 16:20             ` Mark Gross
2007-03-02 17:07               ` Andrew Morton
2007-03-02 17:35                 ` Mark Gross
2007-03-02 18:02                   ` Andrew Morton
2007-03-02 19:02                     ` Mark Gross
2007-03-02 17:16               ` Linus Torvalds
2007-03-02 18:45                 ` Mark Gross
2007-03-02 19:03                   ` Linus Torvalds
2007-03-02 23:58                 ` Martin J. Bligh
2007-03-02  4:18         ` Balbir Singh
2007-03-02  5:13         ` Jeremy Fitzhardinge
2007-03-06  4:16         ` Paul Mackerras
2007-03-02 16:58     ` Mel Gorman
2007-03-02 17:05     ` Joel Schopp
2007-03-05  3:21       ` Nick Piggin
2007-03-05 15:20         ` Joel Schopp
2007-03-05 16:01           ` Nick Piggin
2007-03-05 16:45             ` Joel Schopp
2007-05-03  8:49           ` Andy Whitcroft
2007-03-02  1:39   ` Balbir Singh
2007-03-02  2:34   ` KAMEZAWA Hiroyuki
2007-03-02  3:05   ` Christoph Lameter
2007-03-02  3:57     ` Nick Piggin
2007-03-02  4:06       ` Christoph Lameter
2007-03-02  4:21         ` Nick Piggin
2007-03-02  4:31           ` Christoph Lameter
2007-03-02  5:06             ` Nick Piggin
2007-03-02  5:40               ` Christoph Lameter
2007-03-02  5:49                 ` Nick Piggin
2007-03-02  5:53                   ` Christoph Lameter
2007-03-02  6:08                     ` Nick Piggin
2007-03-02  6:19                       ` Christoph Lameter
2007-03-02  6:29                         ` Nick Piggin
2007-03-02  6:51                           ` Christoph Lameter
2007-03-02  7:03                             ` Andrew Morton
2007-03-02  7:19                             ` Nick Piggin
2007-03-02  7:44                               ` Christoph Lameter
2007-03-02  8:12                                 ` Nick Piggin
2007-03-02  8:21                                   ` Christoph Lameter
2007-03-02  8:38                                     ` Nick Piggin
2007-03-02 17:09                                       ` Christoph Lameter
2007-03-04  1:26                                   ` Rik van Riel
2007-03-04  1:51                                     ` Andrew Morton
2007-03-04  1:58                                       ` Rik van Riel
2007-03-02  5:50               ` Christoph Lameter
2007-03-02  4:29         ` Andrew Morton
2007-03-02  4:33           ` Christoph Lameter
2007-03-02  4:58             ` Andrew Morton
2007-03-02  4:20       ` Paul Mundt
2007-03-02 13:50   ` Arjan van de Ven
2007-03-02 15:29   ` Rik van Riel
2007-03-02 16:58     ` Andrew Morton
2007-03-02 17:09       ` Mel Gorman
2007-03-02 17:23       ` Christoph Lameter
2007-03-02 17:35         ` Andrew Morton
2007-03-02 17:43           ` Rik van Riel
2007-03-02 18:06             ` Andrew Morton
2007-03-02 18:15               ` Christoph Lameter
2007-03-02 18:23                 ` Andrew Morton
2007-03-02 18:23                 ` Rik van Riel
2007-03-02 19:31                   ` Christoph Lameter
2007-03-02 19:40                     ` Rik van Riel
2007-03-02 21:12                   ` Bill Irwin
2007-03-02 21:19                     ` Rik van Riel
2007-03-02 21:52                       ` Andrew Morton
2007-03-02 22:03                         ` Rik van Riel
2007-03-02 22:22                           ` Andrew Morton
2007-03-02 22:34                             ` Rik van Riel
2007-03-02 22:51                               ` Martin Bligh
2007-03-02 22:54                                 ` Rik van Riel
2007-03-02 23:28                                   ` Martin J. Bligh
2007-03-03  0:24                                     ` Andrew Morton
2007-03-02 22:52                               ` Chuck Ebbert
2007-03-02 22:59                               ` Andrew Morton
2007-03-02 23:20                                 ` Rik van Riel
2007-03-03  1:40                                 ` William Lee Irwin III
2007-03-03  1:58                                   ` Andrew Morton
2007-03-03  3:55                                     ` William Lee Irwin III
2007-03-03  0:33                             ` William Lee Irwin III
2007-03-03  0:54                               ` Andrew Morton
2007-03-03  3:15                               ` Christoph Lameter
2007-03-03  4:19                                 ` William Lee Irwin III
2007-03-03 17:16                                 ` Martin J. Bligh
2007-03-03 17:50                                   ` Christoph Lameter
2007-03-02 20:59               ` Bill Irwin
2007-03-02  1:52 ` Bill Irwin
2007-03-02 10:38   ` Mel Gorman [this message]
2007-03-02 16:31     ` Joel Schopp
2007-03-02 21:37       ` Bill Irwin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0703021018070.32022@skynet.skynet.ie \
    --to=mel@csn.ul.ie \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=bill.irwin@oracle.com \
    --cc=clameter@engr.sgi.com \
    --cc=jschopp@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mbligh@mbligh.org \
    --cc=mingo@elte.hu \
    --cc=npiggin@suse.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox