From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Ken Chen <kenchen@google.com>, linux-mm@kvack.org
Subject: Re: [patch] simplify shmem_aops.set_page_dirty method
Date: Wed, 31 Jan 2007 19:17:54 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0701311915230.19297@blonde.wat.veritas.com> (raw)
In-Reply-To: <20070131111146.2b29d851.akpm@osdl.org>
On Wed, 31 Jan 2007, Andrew Morton wrote:
> On Wed, 31 Jan 2007 17:17:10 +0000 (GMT) Hugh Dickins <hugh@veritas.com> wrote:
>
> > 2. Please remind me what good __mark_inode_dirty will do for shmem:
>
> None that I can think of - tmpfs inodes don't get written back to swap (do
> they?)
That's right, tmpfs inodes are only in RAM, only the data can go to swap.
>
> > in my patch the equivalent function did nothing beyond SetPageDirty
> > (your TestSetPageDirty looks better, less redirtying the cacheline).
>
> Will test_and_set_bit() avoid dirtying the cacheline? I guess it _could_
> do this, and perhaps this depends upon the architecture. Perhaps
>
> if (!PageDirty(page))
> SetPageDirty(page);
>
> would be better here.
Synchronicity or telepathy? Our mails on that crossed.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-01-31 19:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-31 4:06 Ken Chen
2007-01-31 17:17 ` Hugh Dickins
2007-01-31 19:11 ` Andrew Morton
2007-01-31 19:17 ` Hugh Dickins [this message]
2007-01-31 21:23 ` Ken Chen
2007-01-31 19:14 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0701311915230.19297@blonde.wat.veritas.com \
--to=hugh@veritas.com \
--cc=akpm@osdl.org \
--cc=kenchen@google.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox