From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 31 Jan 2007 19:14:09 +0000 (GMT) From: Hugh Dickins Subject: Re: [patch] simplify shmem_aops.set_page_dirty method In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Ken Chen Cc: Andrew Morton , linux-mm@kvack.org List-ID: On Wed, 31 Jan 2007, Hugh Dickins wrote: > in my patch the equivalent function did nothing beyond SetPageDirty > (your TestSetPageDirty looks better, less redirtying the cacheline). You've probably been wondering what I meant by that cacheline remark: I was fantasizing TestSetPageDirty(page) as if (PageDirty(page)) return 1; SetPageDirty(page); return 0; whereas of course it's something atomic. Perhaps I had a point, and the less atomic version above is advantageous here: not sure. Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org