From: Hugh Dickins <hugh@veritas.com>
To: Ken Chen <kenchen@google.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-mm@kvack.org
Subject: Re: [patch] simplify shmem_aops.set_page_dirty method
Date: Wed, 31 Jan 2007 19:14:09 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0701311906080.19136@blonde.wat.veritas.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0701311648450.28314@blonde.wat.veritas.com>
On Wed, 31 Jan 2007, Hugh Dickins wrote:
> in my patch the equivalent function did nothing beyond SetPageDirty
> (your TestSetPageDirty looks better, less redirtying the cacheline).
You've probably been wondering what I meant by that cacheline remark:
I was fantasizing TestSetPageDirty(page) as
if (PageDirty(page))
return 1;
SetPageDirty(page);
return 0;
whereas of course it's something atomic. Perhaps I had a point,
and the less atomic version above is advantageous here: not sure.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2007-01-31 19:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-31 4:06 Ken Chen
2007-01-31 17:17 ` Hugh Dickins
2007-01-31 19:11 ` Andrew Morton
2007-01-31 19:17 ` Hugh Dickins
2007-01-31 21:23 ` Ken Chen
2007-01-31 19:14 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0701311906080.19136@blonde.wat.veritas.com \
--to=hugh@veritas.com \
--cc=akpm@osdl.org \
--cc=kenchen@google.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox