From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 26 Jan 2007 16:49:00 +0000 (GMT) From: Mel Gorman Subject: Re: [PATCH 2/8] Create the ZONE_MOVABLE zone In-Reply-To: Message-ID: References: <20070125234458.28809.5412.sendpatchset@skynet.skynet.ie> <20070125234538.28809.24662.sendpatchset@skynet.skynet.ie> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: On Fri, 26 Jan 2007, Christoph Lameter wrote: > On Thu, 25 Jan 2007, Mel Gorman wrote: > >> @@ -166,6 +168,8 @@ enum zone_type { >> #define ZONES_SHIFT 1 >> #elif __ZONE_COUNT <= 4 >> #define ZONES_SHIFT 2 >> +#elif __ZONE_COUNT <= 8 >> +#define ZONES_SHIFT 3 >> #else > > You do not need a shift of 3. Even with ZONE_MOVABLE the maximum > number of zones is still 4. > > x86_64 has DMA, DMA32, NORMAL, MOVABLE > i386 has DMA, NORMAL, HIGHMEM, MOVABLE > > x86_64 is the only platform that has DMA32. > Good point. I'll recheck this to be sure but if it's true, it means that the only major collision point between these patches and the optional ZONE_DMA patches goes away. -- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org