From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sat, 16 Dec 2006 23:08:24 +0000 (GMT) From: Hugh Dickins Subject: Re: 2.6.19 file content corruption on ext3 In-Reply-To: <1166304581.10372.18.camel@twins> Message-ID: References: <20061207155740.GC1434@torres.l21.ma.zugschlus.de> <4578465D.7030104@cfl.rr.com> <20061209092639.GA15443@torres.l21.ma.zugschlus.de> <20061216184310.GA891@unjust.cyrius.com> <1166304581.10372.18.camel@twins> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Peter Zijlstra Cc: Martin Michlmayr , Marc Haber , Jan Kara , linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: On Sat, 16 Dec 2006, Peter Zijlstra wrote: > Moving the cleaning of the page out from under the private_lock opened > up a window where newly attached buffer might still see the page dirty > status and were thus marked (incorrectly) dirty themselves; resulting in > filesystem data corruption. I'm not going to pretend to understand the buffers issues here: people thought that change was safe originally, and I can't say it's not - it just stood out as a potentially weakening change. The patch you propose certainly looks like a good way out, if that moved unlock really is a problem: your patch is very well worth trying by those people seeing their corruption problems, let's wait to hear their feedback. Thanks! Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org