From: Hugh Dickins <hugh@veritas.com>
To: Martin Michlmayr <tbm@cyrius.com>
Cc: Marc Haber <mh+linux-kernel@zugschlus.de>,
Jan Kara <jack@suse.cz>, Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: 2.6.19 file content corruption on ext3
Date: Sat, 16 Dec 2006 19:18:19 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.64.0612161909460.25272@blonde.wat.veritas.com> (raw)
In-Reply-To: <20061216184310.GA891@unjust.cyrius.com>
On Sat, 16 Dec 2006, Martin Michlmayr wrote:
> * Marc Haber <mh+linux-kernel@zugschlus.de> [2006-12-09 10:26]:
> > Unfortunately, I am lacking the knowledge needed to do this in an
> > informed way. I am neither familiar enough with git nor do I possess
> > the necessary C powers.
>
> I wonder if what you're seein is related to
> http://lkml.org/lkml/2006/12/16/73
>
> You said that you don't see any corruption with 2.6.18. Can you try
> to apply the patch from
> http://www2.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=d08b3851da41d0ee60851f2c75b118e1f7a5fc89
> to 2.6.18 to see if the corruption shows up?
I did wonder about the very first hunk of Peter's patch, where the
mapping->private_lock is unlocked earlier now in try_to_free_buffers,
before the clear_page_dirty. I'm not at all familiar with that area,
I wonder if Jan has looked at that change, and might be able to say
whether it's good or not (earlier he worried about his JBD changes,
but they wouldn't be implicated if just 2.6.18+Peter's gives trouble).
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next parent reply other threads:[~2006-12-16 19:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061207155740.GC1434@torres.l21.ma.zugschlus.de>
[not found] ` <4578465D.7030104@cfl.rr.com>
[not found] ` <20061209092639.GA15443@torres.l21.ma.zugschlus.de>
[not found] ` <20061216184310.GA891@unjust.cyrius.com>
2006-12-16 19:18 ` Hugh Dickins [this message]
2006-12-16 21:29 ` Peter Zijlstra
2006-12-16 23:08 ` Hugh Dickins
2006-12-17 13:52 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0612161909460.25272@blonde.wat.veritas.com \
--to=hugh@veritas.com \
--cc=a.p.zijlstra@chello.nl \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mh+linux-kernel@zugschlus.de \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox