[PATCH] slab: fix kmem_ptr_validate prototype

[PATCH] slab: fix kmem_ptr_validate prototype

[Peter Zijlstra]

Some fallout of: 2e892f43ccb602e8ffad73396a1000f2040c9e0b

  CC      mm/slab.o
/usr/src/linux-2.6-git/mm/slab.c:3557: error: conflicting types for a??kmem_ptr_validatea??
/usr/src/linux-2.6-git/include/linux/slab.h:58: error: previous declaration of a??kmem_ptr_validatea?? was here


Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
---
 include/linux/slab.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6-git/include/linux/slab.h
===================================================================
--- linux-2.6-git.orig/include/linux/slab.h	2006-12-14 11:56:35.000000000 +0100
+++ linux-2.6-git/include/linux/slab.h	2006-12-14 11:56:46.000000000 +0100
@@ -55,7 +55,7 @@ void *kmem_cache_zalloc(struct kmem_cach
 void kmem_cache_free(struct kmem_cache *, void *);
 unsigned int kmem_cache_size(struct kmem_cache *);
 const char *kmem_cache_name(struct kmem_cache *);
-int kmem_ptr_validate(struct kmem_cache *cachep, const void *ptr);
+int fastcall kmem_ptr_validate(struct kmem_cache *cachep, const void *ptr);
 
 #ifdef CONFIG_NUMA
 extern void *kmem_cache_alloc_node(struct kmem_cache *, gfp_t flags, int node);


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: [PATCH] slab: fix kmem_ptr_validate prototype

[Christoph Lameter]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 397 bytes --]

On Thu, 14 Dec 2006, Peter Zijlstra wrote:

> Some fallout of: 2e892f43ccb602e8ffad73396a1000f2040c9e0b
> 
>   CC mm/slab.o /usr/src/linux-2.6-git/mm/slab.c:3557: error: conflicting 
> types for ÿÿkmem_ptr_validateÿÿ 
> /usr/src/linux-2.6-git/include/linux/slab.h:58: error: previous 
> declaration of ÿÿkmem_ptr_validateÿÿ was here

Why do we need the fastcall there? What is its role?

Re: [PATCH] slab: fix kmem_ptr_validate prototype

[Christoph Lameter]

The declaration of kmem_ptr_validate in slab.h does not match the
one in slab.c. Remove the fastcall attribute (this is the only use in 
slab.c).

Signed-off-by: Christoph Lameter <clameter@sgi.com>

Index: linux-2.6/mm/slab.c
===================================================================
--- linux-2.6.orig/mm/slab.c	2006-12-14 08:56:59.000000000 -0800
+++ linux-2.6/mm/slab.c	2006-12-14 08:57:10.000000000 -0800
@@ -3553,7 +3553,7 @@ EXPORT_SYMBOL(kmem_cache_zalloc);
  *
  * Currently only used for dentry validation.
  */
-int fastcall kmem_ptr_validate(struct kmem_cache *cachep, const void *ptr)
+int kmem_ptr_validate(struct kmem_cache *cachep, const void *ptr)
 {
 	unsigned long addr = (unsigned long)ptr;
 	unsigned long min_addr = PAGE_OFFSET;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>