From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sat, 9 Dec 2006 11:01:47 -0800 (PST) From: Christoph Lameter Subject: Re: [RFC] Cleanup slab headers / API to allow easy addition of new slab allocators In-Reply-To: <84144f020612090602w5c7f3f9ay8e771763ea8843cf@mail.gmail.com> Message-ID: References: <84144f020612090602w5c7f3f9ay8e771763ea8843cf@mail.gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Pekka Enberg Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Nick Piggin , akpm@osdl.org, mpm@selenic.com, Manfred Spraul List-ID: On Sat, 9 Dec 2006, Pekka Enberg wrote: > Hi Christoph, > > On 12/8/06, Christoph Lameter wrote: > > +#define SLAB_POISON 0x00000800UL /* DEBUG: Poison > > objects */ > > +#define SLAB_HWCACHE_ALIGN 0x00002000UL /* Align objs on > > cache lines */ > > +#define SLAB_CACHE_DMA 0x00004000UL /* Use GFP_DMA memory */ > > +#define SLAB_MUST_HWCACHE_ALIGN 0x00008000UL /* Force alignment > > even if debuggin is active */ > > Please fix formatting while you're at it. Yes I did that. Please look at it after you applied the diff. > > + * its own optimized kmalloc definitions (like SLOB). > > + */ > > + > > +#if defined(CONFIG_NUMA) || defined(CONFIG_DEBUG_SLAB) > > +#error "SLAB fallback definitions not usable for NUMA or Slab debug" > > Do we need this? Shouldn't we just make sure no one can enable > CONFIG_NUMA and CONFIG_DEBUG_SLAB for non-compatible allocators? Ok. Dropped it. > > > -static inline void *kmalloc(size_t size, gfp_t flags) > > +void *kmalloc(size_t size, gfp_t flags) > > static inline? > > > +void *kzalloc(size_t size, gfp_t flags) > > +{ > > + return __kzalloc(size, flags); > > +} > > same here. > Ok. Fixed that. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org