Re: [RFC] Extract kmalloc.h and slob.h from slab.h

[Christoph Lameter <clameter@sgi.com>]

On Wed, 29 Nov 2006, Nick Piggin wrote:

> > NACK.  This is utterly braindead, easily shown by things like the need
> > to duplicate the kmem_cache_alloc prototype.
> > 
> > What are you trying to solve with this?

I am trying to detangle various things in the slab. Its a bit complex.
 
> It does seem wrong, I agree. For another thing, there is no "slob API".
> Slob is an implementation of the *slab API*.

But the definitions vary a lot. Should I try to find the common 
function declarations and keep them together?

> kmalloc seems OK to be split. But given that it is built on top of the
> slab, then it should not be going out of its way to avoid the slab.h
> include, as Christoph H points out.
> 
> If this whole exercise is to dispense with a few includes, then I'll
> second Christoph's nack. This kinds of tricks does not make it easier
> to untangle and redesign header dependencies properly in the long term.

Right now the slab.h is difficult to understand. Separating things out 
will make the .h files small and nicely focused on one thing.

We have some ugly things in kmalloc.h like the include of kmalloc_sizes.h 
and the CACHE definitions. I think those should be separated and then 
hopefully we can fix this up at some point.

Having kmalloc.h separate will also help if we put the definition of 
struct kmem_cache in slab.c. Then the definition will be hidden from the 
simple kmalloc users.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>