From: Pekka J Enberg <penberg@cs.helsinki.fi>
To: Christoph Lameter <clameter@sgi.com>
Cc: akpm@osdl.org, linux-mm@kvack.org, mpm@selenic.com,
Manfred Spraul <manfred@colorfullife.com>
Subject: Re: [RFC] Extract kmalloc.h and slob.h from slab.h
Date: Tue, 28 Nov 2006 21:07:06 +0200 (EET) [thread overview]
Message-ID: <Pine.LNX.4.64.0611282104170.32289@sbz-30.cs.Helsinki.FI> (raw)
In-Reply-To: <Pine.LNX.4.64.0611281003190.8764@schroedinger.engr.sgi.com>
On Tue, 28 Nov 2006, Christoph Lameter wrote:
> What exactly is an in-kernel header?
One that is never ever included by userspace and thus does not need the
guard clause.
On Tue, 28 Nov 2006, Christoph Lameter wrote:
> Why would slab.h be different from kmalloc.h? Yes currently kmalloc.h is
> included by slab.h but in the future code that only relies on kmalloc can
> just include kmalloc.h. Is it because it does not contain any constant
> definitions?
I don't think <linux/slab.h> should have either but I suppose there can be
other (broken) headers that include it and thus its safer not to remove
the guard clause just yet. However, if you wrap the include of
<linux/kmalloc.h> header inside the existing guard then we should be fine,
no?
Pekka
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-11-28 19:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-28 6:33 Christoph Lameter
2006-11-28 8:00 ` Pekka Enberg
2006-11-28 18:05 ` Christoph Lameter
2006-11-28 19:07 ` Pekka J Enberg [this message]
2006-11-28 19:11 ` Christoph Lameter
2006-11-28 19:19 ` Pekka J Enberg
2006-11-28 19:24 ` Pekka Enberg
2006-11-28 19:27 ` Christoph Lameter
2006-11-28 19:25 ` Christoph Lameter
2006-11-28 19:32 ` Pekka Enberg
2006-11-28 19:53 ` Christoph Lameter
2006-11-29 0:30 ` Christoph Lameter
2006-11-29 7:08 ` Pekka Enberg
2006-11-29 19:18 ` Christoph Lameter
2006-11-29 8:26 ` Christoph Hellwig
2006-11-29 8:38 ` Nick Piggin
2006-11-29 19:24 ` Christoph Lameter
2006-11-30 1:58 ` Nick Piggin
2006-11-30 2:43 ` Christoph Lameter
2006-11-30 3:04 ` Nick Piggin
2006-11-30 3:39 ` Christoph Lameter
2006-11-30 3:44 ` Nick Piggin
2006-11-30 3:50 ` Christoph Lameter
2006-11-30 4:18 ` Nick Piggin
2006-11-30 4:28 ` Christoph Lameter
2006-11-30 5:01 ` Nick Piggin
2006-11-30 7:12 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0611282104170.32289@sbz-30.cs.Helsinki.FI \
--to=penberg@cs.helsinki.fi \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-mm@kvack.org \
--cc=manfred@colorfullife.com \
--cc=mpm@selenic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox