linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@sgi.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: akpm@osdl.org, linux-mm@kvack.org, Linus Torvalds <torvalds@osdl.org>
Subject: Re: Slab: Remove kmem_cache_t
Date: Tue, 28 Nov 2006 19:32:19 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0611281923460.12646@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <456D0757.6050903@yahoo.com.au>

On Wed, 29 Nov 2006, Nick Piggin wrote:

> Christoph Lameter wrote:
> > This patch replaces all uses of kmem_cache_t with struct kmem_cache.
> kmem_cache really is an opaque type outside of mm/slab.c, isn't it?

kmem_cache_t would require a declaration. struct kmem_cache * can be used 
without a prior declaration in include files. Please review the earlier 
discussion on linux-mm regarding the removal of the global slab caches 
from <linux/slab.h>.

Frankly the maintenance of the opaque type here has caused us enough grief 
over the years. I would like to get rid of it in the future and declare 
the contents of struct kmem_cache in slab.h. That will allow us to 
simplify the slab bootstrap and make it easier to understand. One 
reason slab bootstrap is so complex because one cannot simple do a static 
declaration of a struct kmem_cache and start off with it. See the earlier 
discussion with Matt Mackall on the slabifier design.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2006-11-29  3:32 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-29  2:49 Christoph Lameter
2006-11-29  3:06 ` Andrew Morton
2006-11-29  4:06 ` Nick Piggin
2006-11-29  3:32   ` Christoph Lameter [this message]
2006-11-29  4:42     ` Nick Piggin
2006-11-29  3:48       ` Nick Piggin
2006-11-29  4:06       ` Andrew Morton
2006-11-29  4:38         ` Linus Torvalds
2006-11-29  5:51           ` Nick Piggin
2006-11-29 15:48             ` Linus Torvalds
2006-11-30  1:40               ` Nick Piggin
2006-11-30  1:59                 ` Linus Torvalds
2006-11-30  2:14                   ` Nick Piggin
2006-11-30  2:37                     ` Linus Torvalds
2006-11-30  2:51                       ` Nick Piggin
2006-11-29  6:21           ` Nick Piggin
2006-11-29 16:11             ` Linus Torvalds
2006-11-29  5:41         ` Nick Piggin
2006-11-29  6:24           ` Andrew Morton
2006-11-29  6:41             ` Nick Piggin
2006-11-29  7:08               ` Andrew Morton
2006-11-29  7:23                 ` Nick Piggin
2006-11-29  7:41                   ` Andrew Morton
2006-11-29  8:04                     ` Nick Piggin
2006-11-29 16:23                       ` Linus Torvalds
2006-11-30  1:44                         ` Nick Piggin
2006-11-29 19:16               ` Christoph Lameter
2006-11-29  8:50 ` Peter Zijlstra
2006-11-29 19:27   ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0611281923460.12646@schroedinger.engr.sgi.com \
    --to=clameter@sgi.com \
    --cc=akpm@osdl.org \
    --cc=linux-mm@kvack.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox