From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 2 Nov 2006 14:50:25 -0800 (PST) From: Christoph Lameter Subject: Re: Page allocator: Single Zone optimizations In-Reply-To: Message-ID: References: <20061027190452.6ff86cae.akpm@osdl.org> <20061027192429.42bb4be4.akpm@osdl.org> <20061027214324.4f80e992.akpm@osdl.org> <20061028180402.7c3e6ad8.akpm@osdl.org> <4544914F.3000502@yahoo.com.au> <20061101182605.GC27386@skynet.ie> <20061101123451.3fd6cfa4.akpm@osdl.org> <454A2CE5.6080003@shadowen.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Mel Gorman Cc: Andy Whitcroft , Andrew Morton , Nick Piggin , KAMEZAWA Hiroyuki , Linux Memory Management List , Peter Zijlstra List-ID: On Thu, 2 Nov 2006, Mel Gorman wrote: > > Reclaim is a way of > > evicting pages from memory to avoid the move. This may be useful if memory > > is filled up because defragging can then do what swapping would have to > > do. However, evicting pages means that they have to be reread. Page > > migration can migrate pages at 1GB/sec which is certainly much higher > > than having to reread the page. > The reason why anti-frag currently reclaims is because reclaiming was easy and > happens under memory pressure not because I thought pageout was free. As a > proof-of-concept, I needed to show that pages clustered on reclaimability > would free contiguous blocks of pages later. There was no point starting with > defragmentation when I knew that unmovable pages would be with movable pages > in the same MAX_ORDER_NR_PAGES block. Could you go to defrag with what we have discussed now? > > 1. An mlocked page. This is a page that is movable but not reclaimable. > > How does defrag handle that case right now? It should really move the > > page if necessary. > > > > Defrag doesn't exist right now. If anti-frag got some traction, working on > using page migration to handle movable-but-not-reclaimable pages would be the > next step. Pages that are mlocked() will have been allocated with > __GFP_EASYRCLM so will be clustered together with other movable pages. But mlocked pages are not reclaimable. > > 2. There are a number of unreclaimable page types that are easily movable. > > F.e. page table pages are movable if you take a write-lock on mmap_sem > > and handle the tree carefully. These pages again are not reclaimable but > > they are movable. > > > > Page tables are currently not allocated with __GFP_EASYRCLM because I knew I > couldn't reclaim them without killing processes. However, if page migration > within ranges was implemented, we'd start clustering based on movability > instead of reclaimability. There would have to be a separate function to move page table pages since they cannot be handled like regular pages. We would need some way of id'ing the mm struct the page belongs to in order to get to the top of the tree and to mmap_sem. > > Various caching objects in the slab (cpucache align cache etc) are also > > easily movable. If we put them into a separate slab cache then we could > > make them movable. > As subsystems will have pointers to objects within the slab, I doubt they are > easily movable but I'll take your word on it for the moment. The slab already has these pointers in the page struct. They are needed to id the slab on kfree(). We already reallocate all caches when we tune the cpucaches. So there is not much new for the slab cache objects. > > I would suggest to not categorize pages according to their reclaimability > > but according to their movability. > > ok, I see your point. However, reclaimability seems a reasonable starting > point. If I know pages of similar reclaimability are clustered together, I can > work on using page migration to move pages out of the blocks of known > reclaimability instead of paging them out. When that works, the __GFP_ flags > identifying reclaimability can be renamed to marking movability and flag page > table pages as well. This is a logical progression. I'd rather go direct to defrag instead of creating churn with fragmentation avoidance. > Agreed, but swapping them out was an easier starting point. I think this work is very valuable and the acceptance issues have probably dominated the design of the patch so far. But I sure wish we would now go to the full thing instead of an intermediate step that we then will have to undo later. An intemediate step that would make sense is starting to marking pages as unmovable and then reclaim movable pages. Then we can add more and more logic to make move pages movable on top. With marking pages for reclaim we wont get there. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org