From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 27 Oct 2006 06:24:33 -0700 (PDT) From: Christoph Lameter Subject: Re: [PATCH 2/3] Create compat_sys_migrate_pages In-Reply-To: <20061027102834.5db261af.sfr@canb.auug.org.au> Message-ID: References: <20061026132659.2ff90dd1.sfr@canb.auug.org.au> <20061026133305.b0db54e6.sfr@canb.auug.org.au> <20061027102834.5db261af.sfr@canb.auug.org.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Stephen Rothwell Cc: LKML , ppc-dev , paulus@samba.org, ak@suse.de, linux-mm@kvack.org List-ID: On Fri, 27 Oct 2006, Stephen Rothwell wrote: > No they aren't because they have compat routines that convert the bitmaps > before calling the "normal" syscall. They, importantly, only use > compat_alloc_user_space once each. Ah... > > Fixing get_nodes() to do the proper thing would fix all of these > > without having to touch sys_migrate_pages or creating a compat_ function > > (which usually is placed in kernel/compat.c) > > You need the compat_ version of the syscalls to know if you were called > from a 32bit application in order to know if you may need to fixup the > bitmaps that are passed from/to user mode. The compat functions should be placed in kernel/compat.c next to compat_sys_move_pages. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org