From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 26 Oct 2006 12:00:30 -0700 (PDT) From: Christoph Lameter Subject: Re: [PATCH 2/3] Create compat_sys_migrate_pages In-Reply-To: <20061026133305.b0db54e6.sfr@canb.auug.org.au> Message-ID: References: <20061026132659.2ff90dd1.sfr@canb.auug.org.au> <20061026133305.b0db54e6.sfr@canb.auug.org.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Stephen Rothwell Cc: LKML , ppc-dev , paulus@samba.org, ak@suse.de, linux-mm@kvack.org List-ID: On Thu, 26 Oct 2006, Stephen Rothwell wrote: > This is needed on bigendian 64bit architectures. The obvious way to do > this (taking the other compat_ routines in this file as examples) is to > use compat_alloc_user_space and copy the bitmasks back there, however you > cannot call compat_alloc_user_space twice for a single system call and > this method saves two copies of the bitmasks. Well this means also that sys_mbind and sys_set_mempolicy are also broken because these functions also use get_nodes(). Fixing get_nodes() to do the proper thing would fix all of these without having to touch sys_migrate_pages or creating a compat_ function (which usually is placed in kernel/compat.c) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org