From: Hugh Dickins <hugh@veritas.com>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: 'Andrew Morton' <akpm@osdl.org>, Hugh Blemings <hab@au1.ibm.com>,
linux-mm@kvack.org
Subject: Re: [patch 1/2] shared page table for hugetlb page - v4
Date: Fri, 20 Oct 2006 23:10:31 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0610202253190.963@blonde.wat.veritas.com> (raw)
In-Reply-To: <000001c6f3b2$0c70b8c0$ff0da8c0@amr.corp.intel.com>
On Thu, 19 Oct 2006, Chen, Kenneth W wrote:
> Re-diff against git tree as of this morning since some of the changes
> were committed for a different reason. No other change from last version.
> I was hoping Hugh finds time to review version v4 posted about two weeks
> ago. Though I don't want to wait for too long to rebase. So here we go:
They both look fine to me now, Ken.
(I was expecting a problem with your vma_prio_tree_fornext idx, but
testing showed I was wrong about that: as I guess you already found,
it's the h_pgoff in hugetlb_vmtruncate_list's vma_prio_tree_fornext
which is wrong, but wrong in a safe way so we've never noticed:
I'll test and send in a patch for that tomorrow.)
You can add my
Acked-by: Hugh Dickins <hugh@veritas.com>
to both patches, but it's no longer worth much: I notice Andrew has
grown so disillusioned by my sluggardly responses that he's rightly
decided to CC Hugh Blemings instead ;) Over to you, Hugh!
HughD
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-10-20 22:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 19:09 Chen, Kenneth W
2006-10-20 22:10 ` Hugh Dickins [this message]
2006-10-21 4:03 ` Hugh Blemings
-- strict thread matches above, loose matches on Subject: below --
2006-10-03 9:57 Chen, Kenneth W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0610202253190.963@blonde.wat.veritas.com \
--to=hugh@veritas.com \
--cc=akpm@osdl.org \
--cc=hab@au1.ibm.com \
--cc=kenneth.w.chen@intel.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox