linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* No GFP_DMA check in the slab if no CONFIG_ZONE_DMA is set
@ 2006-10-17  0:43 Christoph Lameter
  0 siblings, 0 replies; only message in thread
From: Christoph Lameter @ 2006-10-17  0:43 UTC (permalink / raw)
  To: akpm; +Cc: linux-mm

The GFP_DMA check in the slab is not necessary if there is no ZONE_DMA available.

The SCSI layer still sets GFP_DMA just in case which may cause the
BUG_ON to fire although there cannot be a an issue since systems with 
CONFIG_ZONE_DMA off have no DMA restrictions.

This bug was triggered by Paul Jackson on an SGI Altix system. Altix never 
had any memory below 4G (meaning of ZONE_DMA on ia64) and the driver has
been working for ages.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

Index: linux-2.6.19-rc1-mm1/mm/slab.c
===================================================================
--- linux-2.6.19-rc1-mm1.orig/mm/slab.c	2006-10-16 03:42:42.000000000 -0500
+++ linux-2.6.19-rc1-mm1/mm/slab.c	2006-10-16 18:47:43.900899030 -0500
@@ -2624,10 +2624,12 @@ static void cache_init_objs(struct kmem_
 
 static void kmem_flagcheck(struct kmem_cache *cachep, gfp_t flags)
 {
+#ifdef CONFIG_ZONE_DMA
 	if (flags & SLAB_DMA)
 		BUG_ON(!(cachep->gfpflags & GFP_DMA));
 	else
 		BUG_ON(cachep->gfpflags & GFP_DMA);
+#endif
 }
 
 static void *slab_get_obj(struct kmem_cache *cachep, struct slab *slabp,

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-10-17  0:43 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-10-17  0:43 No GFP_DMA check in the slab if no CONFIG_ZONE_DMA is set Christoph Lameter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox