From: Christoph Lameter <clameter@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Andy Whitcroft <apw@shadowen.org>,
linux-mm@kvack.org, Dave Hansen <haveblue@us.ibm.com>
Subject: Re: [PATCH] Get rid of zone_table V2
Date: Mon, 2 Oct 2006 10:10:48 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0610021008510.12554@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20060930130811.2a7c0009.akpm@osdl.org>
On Sat, 30 Sep 2006, Andrew Morton wrote:
> BUILD_BUG_ON()?
Good idea. We may want to take all of these patches out if Andy can come
up with an easy modification to the macros that avoids ZONEID_PGSHIFT to
unintentionally become 0.
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Index: linux-2.6.18-mm2/include/linux/mm.h
===================================================================
--- linux-2.6.18-mm2.orig/include/linux/mm.h 2006-09-30 13:33:27.000000000 -0500
+++ linux-2.6.18-mm2/include/linux/mm.h 2006-10-02 12:08:14.387946148 -0500
@@ -452,7 +452,7 @@ static inline enum zone_type page_zonenu
*/
static inline int page_zone_id(struct page *page)
{
- BUG_ON(ZONEID_PGSHIFT == 0 && ZONEID_MASK);
+ BUILD_BUG_ON(ZONEID_PGSHIFT == 0 && ZONEID_MASK);
return (page->flags >> ZONEID_PGSHIFT) & ZONEID_MASK;
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-10-02 17:10 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-18 19:21 Christoph Lameter
2006-09-18 20:28 ` Andrew Morton
2006-09-18 22:51 ` Christoph Lameter
2006-09-18 23:15 ` Andrew Morton
2006-09-18 23:46 ` Christoph Lameter
2006-09-18 23:58 ` Andrew Morton
2006-09-19 0:08 ` Christoph Lameter
2006-09-19 0:14 ` Christoph Lameter
2006-09-19 0:31 ` Andrew Morton
2006-09-19 1:20 ` Christoph Lameter
2006-09-19 6:12 ` Christoph Lameter
2006-09-19 6:33 ` Andrew Morton
2006-09-19 14:10 ` Christoph Lameter
2006-09-19 15:38 ` Andrew Morton
2006-09-19 15:41 ` Christoph Lameter
2006-09-19 16:23 ` Nick Piggin
2006-09-19 16:45 ` Nick Piggin
2006-09-19 17:50 ` Christoph Lameter
2006-09-19 18:24 ` Andi Kleen
2006-09-19 16:17 ` Nick Piggin
2006-09-24 10:06 ` Andrew Morton
2006-09-24 16:58 ` Christoph Lameter
2006-09-27 9:19 ` Andrew Morton
2006-09-27 9:26 ` Andy Whitcroft
2006-09-27 11:23 ` [PATCH] zone table removal miss merge Andy Whitcroft
2006-09-27 16:19 ` Christoph Lameter
2006-09-27 11:27 ` [PATCH] Get rid of zone_table V2 Andy Whitcroft
2006-09-27 16:24 ` Andrew Morton
2006-09-30 18:47 ` Christoph Lameter
2006-09-30 18:48 ` Christoph Lameter
2006-09-30 20:08 ` Andrew Morton
2006-10-02 15:57 ` Christoph Lameter
2006-10-02 17:10 ` Christoph Lameter [this message]
2006-10-04 10:10 ` Andy Whitcroft
2006-10-06 14:45 ` [PATCH] zoneid fix up calculations for ZONEID_PGSHIFT Andy Whitcroft
2006-10-06 17:00 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0610021008510.12554@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=haveblue@us.ibm.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox