From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 22 Sep 2006 14:01:48 -0700 (PDT) From: Christoph Lameter Subject: Re: [RFC] Initial alpha-0 for new page allocator API In-Reply-To: <200609221341.44354.jesse.barnes@intel.com> Message-ID: References: <4514441E.70207@mbligh.org> <200609221341.44354.jesse.barnes@intel.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Jesse Barnes Cc: Martin Bligh , Andi Kleen , Alan Cox , akpm@google.com, linux-kernel@vger.kernel.org, Christoph Hellwig , James Bottomley , linux-mm@kvack.org List-ID: On Fri, 22 Sep 2006, Jesse Barnes wrote: > > + if (dev->coherent_dma_mask < 0xffffffff) > > + high = dev->coherent_dma_mask; > > With your alloc_pages_range this check can go away. I think only the dev > == NULL check is needed with this scheme since it looks like there's no > way (currently) for ISA devices to store their masks for later > consultation by arch code? This check is necessary to set up the correct high boundary for alloc_page_range. > > + if (high == -1L && low == 0L) > > + return alloc_pages(gfp_flags, order); > > There's max_pfn, but on machines with large memory holes using it might not > help much. I found node_start_pfn and node_spanned_pages in the node structure. That gives me the boundaries for a node and I think I can work with that. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org