From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 25 Aug 2006 17:30:09 -0700 (PDT) From: Christoph Lameter Subject: Re: ZVC: Support NR_SLAB_RECLAIM In-Reply-To: <20060825165659.0d8c03d4.akpm@osdl.org> Message-ID: References: <20060825165659.0d8c03d4.akpm@osdl.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: npiggin@suse.de, linux-mm@kvack.org List-ID: On Fri, 25 Aug 2006, Andrew Morton wrote: > On Fri, 25 Aug 2006 15:16:19 -0700 (PDT) > Christoph Lameter wrote: > > > Remove the atomic counter for slab_reclaim_pages and replace > > with a ZVC counter. NR_SLAB will now only count the > > unreclaimable slab pages whereas NR_SLAB_RECLAIM will count > > the reclaimable slab pages. > > That's misleading. We should rename NR_SLAB to NR_SLAB_UNRECLAIMABLE. And > NR_SLAB_RECLAIM should be NR_SLAB_RECLAIMABLE, no? Thats a bit long but yes we could do that. > > n += hugetlb_report_node_meminfo(nid, buf + n); > > return n; > > That breaks anything which uses the Slab: field. OK, so it's NUMA geeks > only. But still.. Well we already changed lots of names when we introduced the ZVCs. > We can add new fields though, so let's just have Slab:, SlabUnrecl: (ug) > and SlabReclaim: (ug). Allright new patches will follow soon. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org