From: Christoph Lameter <clameter@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: npiggin@suse.de, linux-mm@kvack.org
Subject: Re: ZVC: Support NR_SLAB_RECLAIM
Date: Fri, 25 Aug 2006 17:30:09 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0608251728240.11715@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20060825165659.0d8c03d4.akpm@osdl.org>
On Fri, 25 Aug 2006, Andrew Morton wrote:
> On Fri, 25 Aug 2006 15:16:19 -0700 (PDT)
> Christoph Lameter <clameter@sgi.com> wrote:
>
> > Remove the atomic counter for slab_reclaim_pages and replace
> > with a ZVC counter. NR_SLAB will now only count the
> > unreclaimable slab pages whereas NR_SLAB_RECLAIM will count
> > the reclaimable slab pages.
>
> That's misleading. We should rename NR_SLAB to NR_SLAB_UNRECLAIMABLE. And
> NR_SLAB_RECLAIM should be NR_SLAB_RECLAIMABLE, no?
Thats a bit long but yes we could do that.
> > n += hugetlb_report_node_meminfo(nid, buf + n);
> > return n;
>
> That breaks anything which uses the Slab: field. OK, so it's NUMA geeks
> only. But still..
Well we already changed lots of names when we introduced the ZVCs.
> We can add new fields though, so let's just have Slab:, SlabUnrecl: (ug)
> and SlabReclaim: (ug).
Allright new patches will follow soon.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-08-26 0:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-25 22:16 Christoph Lameter
2006-08-25 22:22 ` zone_reclaim: dynamic zone based slab reclaim Christoph Lameter
2006-08-25 23:42 ` Andrew Morton
2006-08-26 0:27 ` Christoph Lameter
2006-08-26 0:48 ` Andrew Morton
2006-08-25 23:56 ` ZVC: Support NR_SLAB_RECLAIM Andrew Morton
2006-08-26 0:30 ` Christoph Lameter [this message]
2006-08-26 0:55 ` Andrew Morton
2006-08-26 0:58 ` Christoph Lameter
2006-08-26 1:07 ` Andrew Morton
2006-08-26 1:10 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0608251728240.11715@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox