From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 25 Aug 2006 15:16:19 -0700 (PDT) From: Christoph Lameter Subject: ZVC: Support NR_SLAB_RECLAIM Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: akpm@osdl.org Cc: npiggin@suse.de, linux-mm@kvack.org List-ID: Remove the atomic counter for slab_reclaim_pages and replace with a ZVC counter. NR_SLAB will now only count the unreclaimable slab pages whereas NR_SLAB_RECLAIM will count the reclaimable slab pages. Change the check in vmscan.c to refer to NR_SLAB_RECLAIM. The intend seems to be to check for slab pages that could be freed. Signed-off-by: Christoph Lameter Index: linux-2.6.18-rc4-mm2/mm/mmap.c =================================================================== --- linux-2.6.18-rc4-mm2.orig/mm/mmap.c 2006-08-23 12:37:01.836055970 -0700 +++ linux-2.6.18-rc4-mm2/mm/mmap.c 2006-08-25 14:23:03.839764012 -0700 @@ -112,7 +112,7 @@ int __vm_enough_memory(long pages, int c * which are reclaimable, under pressure. The dentry * cache and most inode caches should fall into this */ - free += atomic_read(&slab_reclaim_pages); + free += global_page_state(NR_SLAB_RECLAIM); /* * Leave the last 3% for root Index: linux-2.6.18-rc4-mm2/mm/slab.c =================================================================== --- linux-2.6.18-rc4-mm2.orig/mm/slab.c 2006-08-23 12:37:01.858515518 -0700 +++ linux-2.6.18-rc4-mm2/mm/slab.c 2006-08-25 14:23:03.842693518 -0700 @@ -738,14 +738,6 @@ static DEFINE_MUTEX(cache_chain_mutex); static struct list_head cache_chain; /* - * vm_enough_memory() looks at this to determine how many slab-allocated pages - * are possibly freeable under pressure - * - * SLAB_RECLAIM_ACCOUNT turns this on per-slab - */ -atomic_t slab_reclaim_pages; - -/* * chicken and egg problem: delay the per-cpu array allocation * until the general caches are up. */ @@ -1582,8 +1574,9 @@ static void *kmem_getpages(struct kmem_c nr_pages = (1 << cachep->gfporder); if (cachep->flags & SLAB_RECLAIM_ACCOUNT) - atomic_add(nr_pages, &slab_reclaim_pages); - add_zone_page_state(page_zone(page), NR_SLAB, nr_pages); + add_zone_page_state(page_zone(page), NR_SLAB_RECLAIM, nr_pages); + else + add_zone_page_state(page_zone(page), NR_SLAB, nr_pages); for (i = 0; i < nr_pages; i++) __SetPageSlab(page + i); return page_address(page); @@ -1598,7 +1591,10 @@ static void kmem_freepages(struct kmem_c struct page *page = virt_to_page(addr); const unsigned long nr_freed = i; - sub_zone_page_state(page_zone(page), NR_SLAB, nr_freed); + if (cachep->flags & SLAB_RECLAIM_ACCOUNT) + sub_zone_page_state(page_zone(page), NR_SLAB_RECLAIM, nr_freed); + else + sub_zone_page_state(page_zone(page), NR_SLAB, nr_freed); while (i--) { BUG_ON(!PageSlab(page)); __ClearPageSlab(page); @@ -1607,8 +1603,6 @@ static void kmem_freepages(struct kmem_c if (current->reclaim_state) current->reclaim_state->reclaimed_slab += nr_freed; free_pages((unsigned long)addr, cachep->gfporder); - if (cachep->flags & SLAB_RECLAIM_ACCOUNT) - atomic_sub(1 << cachep->gfporder, &slab_reclaim_pages); } static void kmem_rcu_free(struct rcu_head *head) Index: linux-2.6.18-rc4-mm2/mm/slob.c =================================================================== --- linux-2.6.18-rc4-mm2.orig/mm/slob.c 2006-08-06 11:20:11.000000000 -0700 +++ linux-2.6.18-rc4-mm2/mm/slob.c 2006-08-25 14:23:03.842693518 -0700 @@ -340,9 +340,6 @@ void kmem_cache_init(void) mod_timer(&slob_timer, jiffies + HZ); } -atomic_t slab_reclaim_pages = ATOMIC_INIT(0); -EXPORT_SYMBOL(slab_reclaim_pages); - #ifdef CONFIG_SMP void *__alloc_percpu(size_t size) Index: linux-2.6.18-rc4-mm2/mm/nommu.c =================================================================== --- linux-2.6.18-rc4-mm2.orig/mm/nommu.c 2006-08-06 11:20:11.000000000 -0700 +++ linux-2.6.18-rc4-mm2/mm/nommu.c 2006-08-25 14:23:03.843670020 -0700 @@ -1133,7 +1133,7 @@ int __vm_enough_memory(long pages, int c * which are reclaimable, under pressure. The dentry * cache and most inode caches should fall into this */ - free += atomic_read(&slab_reclaim_pages); + free += global_page_state(NR_SLAB_RECLAIM); /* * Leave the last 3% for root Index: linux-2.6.18-rc4-mm2/include/linux/slab.h =================================================================== --- linux-2.6.18-rc4-mm2.orig/include/linux/slab.h 2006-08-23 12:37:01.493303726 -0700 +++ linux-2.6.18-rc4-mm2/include/linux/slab.h 2006-08-25 14:23:03.844646522 -0700 @@ -291,8 +291,6 @@ extern kmem_cache_t *fs_cachep; extern kmem_cache_t *sighand_cachep; extern kmem_cache_t *bio_cachep; -extern atomic_t slab_reclaim_pages; - #endif /* __KERNEL__ */ #endif /* _LINUX_SLAB_H */ Index: linux-2.6.18-rc4-mm2/include/linux/mmzone.h =================================================================== --- linux-2.6.18-rc4-mm2.orig/include/linux/mmzone.h 2006-08-23 12:37:01.103679381 -0700 +++ linux-2.6.18-rc4-mm2/include/linux/mmzone.h 2006-08-25 14:23:03.845623024 -0700 @@ -51,7 +51,8 @@ enum zone_stat_item { NR_FILE_MAPPED, /* pagecache pages mapped into pagetables. only modified from process context */ NR_FILE_PAGES, - NR_SLAB, /* Pages used by slab allocator */ + NR_SLAB, /* Unreclaimable slab pages */ + NR_SLAB_RECLAIM, /* Reclaimable slab pages */ NR_PAGETABLE, /* used for pagetables */ NR_FILE_DIRTY, NR_WRITEBACK, Index: linux-2.6.18-rc4-mm2/drivers/base/node.c =================================================================== --- linux-2.6.18-rc4-mm2.orig/drivers/base/node.c 2006-08-23 12:36:56.875425210 -0700 +++ linux-2.6.18-rc4-mm2/drivers/base/node.c 2006-08-25 14:42:05.130443045 -0700 @@ -68,7 +68,8 @@ static ssize_t node_read_meminfo(struct "Node %d PageTables: %8lu kB\n" "Node %d NFS Unstable: %8lu kB\n" "Node %d Bounce: %8lu kB\n" - "Node %d Slab: %8lu kB\n", + "Node %d SlabUnrecl: %8lu kB\n" + "Node %d SlabReclaim: %8lu kB\n", nid, K(i.totalram), nid, K(i.freeram), nid, K(i.totalram - i.freeram), @@ -88,7 +89,8 @@ static ssize_t node_read_meminfo(struct nid, K(node_page_state(nid, NR_PAGETABLE)), nid, K(node_page_state(nid, NR_UNSTABLE_NFS)), nid, K(node_page_state(nid, NR_BOUNCE)), - nid, K(node_page_state(nid, NR_SLAB))); + nid, K(node_page_state(nid, NR_SLAB)), + nid, K(node_page_state(nid, NR_SLAB_RECLAIM))); n += hugetlb_report_node_meminfo(nid, buf + n); return n; } Index: linux-2.6.18-rc4-mm2/mm/vmstat.c =================================================================== --- linux-2.6.18-rc4-mm2.orig/mm/vmstat.c 2006-08-23 12:37:01.866327535 -0700 +++ linux-2.6.18-rc4-mm2/mm/vmstat.c 2006-08-25 14:23:03.846599525 -0700 @@ -395,6 +395,7 @@ static char *vmstat_text[] = { "nr_mapped", "nr_file_pages", "nr_slab", + "nr_slab_reclaim", "nr_page_table_pages", "nr_dirty", "nr_writeback", Index: linux-2.6.18-rc4-mm2/fs/proc/proc_misc.c =================================================================== --- linux-2.6.18-rc4-mm2.orig/fs/proc/proc_misc.c 2006-08-23 12:36:59.772706994 -0700 +++ linux-2.6.18-rc4-mm2/fs/proc/proc_misc.c 2006-08-25 14:23:03.848552529 -0700 @@ -170,7 +170,8 @@ static int meminfo_read_proc(char *page, "Writeback: %8lu kB\n" "AnonPages: %8lu kB\n" "Mapped: %8lu kB\n" - "Slab: %8lu kB\n" + "SlabUnrecl: %8lu kB\n" + "SlabReclaim: %8lu kB\n" "PageTables: %8lu kB\n" "NFS Unstable: %8lu kB\n" "Bounce: %8lu kB\n" @@ -199,6 +200,7 @@ static int meminfo_read_proc(char *page, K(global_page_state(NR_ANON_PAGES)), K(global_page_state(NR_FILE_MAPPED)), K(global_page_state(NR_SLAB)), + K(global_page_state(NR_SLAB_RECLAIM)), K(global_page_state(NR_PAGETABLE)), K(global_page_state(NR_UNSTABLE_NFS)), K(global_page_state(NR_BOUNCE)), Index: linux-2.6.18-rc4-mm2/mm/swap_prefetch.c =================================================================== --- linux-2.6.18-rc4-mm2.orig/mm/swap_prefetch.c 2006-08-23 12:37:01.860468523 -0700 +++ linux-2.6.18-rc4-mm2/mm/swap_prefetch.c 2006-08-25 14:23:03.848552529 -0700 @@ -393,6 +393,7 @@ static int prefetch_suitable(void) */ limit = node_page_state(node, NR_FILE_PAGES); limit += node_page_state(node, NR_SLAB); + limit += node_page_state(node, NR_SLAB_RECLAIM); limit += node_page_state(node, NR_FILE_DIRTY); limit += node_page_state(node, NR_UNSTABLE_NFS); limit += total_swapcache_pages; Index: linux-2.6.18-rc4-mm2/mm/vmscan.c =================================================================== --- linux-2.6.18-rc4-mm2.orig/mm/vmscan.c 2006-08-23 12:37:01.865351033 -0700 +++ linux-2.6.18-rc4-mm2/mm/vmscan.c 2006-08-25 14:23:03.849529031 -0700 @@ -1386,7 +1386,7 @@ unsigned long shrink_all_memory(unsigned for_each_zone(zone) lru_pages += zone->nr_active + zone->nr_inactive; - nr_slab = global_page_state(NR_SLAB); + nr_slab = global_page_state(NR_SLAB_RECLAIM); /* If slab caches are huge, it's better to hit them first */ while (nr_slab >= lru_pages) { reclaim_state.reclaimed_slab = 0; -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org