From: Christoph Lameter <clameter@sgi.com>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [RFC][PATCH] unify all architecture PAGE_SIZE definitions
Date: Fri, 25 Aug 2006 08:42:11 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0608250838410.9083@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20060824234430.6AC970F7@localhost.localdomain>
I think this is a good thing to do. However, the patch as it is now is
difficult to review. Could you split the patch into multiple patches? One
patch that introduces the generic functionality and then do one patch
per arch? It would be best to sent the arch specific patches to the arch
mailing list or the arch maintainer for review.
You probably can get the generic piece into mm together with the first
arch specific patch (once the first arch has signed off) and then submit
further bits as the reviews get completed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-08-25 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-24 23:44 Dave Hansen
2006-08-25 15:42 ` Christoph Lameter [this message]
2006-08-25 15:51 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0608250838410.9083@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox