From: Christoph Lameter <clameter@sgi.com>
To: Andi Kleen <ak@suse.de>
Cc: akpm@osdl.org, linux-mm@kvack.org
Subject: Re: Profiling: Require buffer allocation on the correct node
Date: Wed, 9 Aug 2006 21:53:44 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0608092152120.5748@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <200608100521.19783.ak@suse.de>
On Thu, 10 Aug 2006, Andi Kleen wrote:
> On Thursday 10 August 2006 04:18, Christoph Lameter wrote:
> > Profiling really suffers with off node buffers. Fail if no memory is available
> > on the nodes. The profiling code can deal with these failures should
> > they occur.
>
> At least for Opterons and other small NUMAs I have my doubts this is a good strategy.
> However it probably shouldn't happen very often, but if it happened it would be
> the wrong thing.
>
> In general shouldn't there be a printk at least? Doing such things silently is a bit
> nasty.
The code already checks for failing allocations and it gives a messages
AFAIK. This is just a fix so that the allocator does what they thought it
would be doing.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2006-08-10 4:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-10 2:18 Christoph Lameter
2006-08-10 3:21 ` Andi Kleen
2006-08-10 4:53 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0608092152120.5748@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox