From: Christoph Lameter <clameter@sgi.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: akpm@osdl.org, linux-mm@kvack.org, pj@sgi.com, jes@sgi.com,
Andy Whitcroft <apw@shadowen.org>
Subject: Re: [1/3] Add __GFP_THISNODE to avoid fallback to other nodes and ignore cpuset/memory policy restrictions.
Date: Tue, 8 Aug 2006 10:51:58 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0608081049040.28259@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0608081807380.24142@skynet.skynet.ie>
On Tue, 8 Aug 2006, Mel Gorman wrote:
> > From your set of patches, it's only used for page migration and the IA64
> uncached allocator both of which are using alloc_pages_node() at the moment.
> Do you see a widespread need to avoid fallbacks in other areas?
These are the patches that are ready for mm. Read the other RFCs on
linux-mm. There are patches for the slab etc.
> Also, I just noticed you didn't update GFP_LEVEL_MASK with your new flag. That
> may cause interesting failures in the future, particularly if you call into
> the slab allocator with the new flag.
Thanks! Fixup:
Index: linux-2.6.18-rc3-mm2/include/linux/gfp.h
===================================================================
--- linux-2.6.18-rc3-mm2.orig/include/linux/gfp.h 2006-08-08 09:20:41.727897528 -0700
+++ linux-2.6.18-rc3-mm2/include/linux/gfp.h 2006-08-08 10:50:37.604766523 -0700
@@ -54,7 +54,7 @@ struct vm_area_struct;
#define GFP_LEVEL_MASK (__GFP_WAIT|__GFP_HIGH|__GFP_IO|__GFP_FS| \
__GFP_COLD|__GFP_NOWARN|__GFP_REPEAT| \
__GFP_NOFAIL|__GFP_NORETRY|__GFP_NO_GROW|__GFP_COMP| \
- __GFP_NOMEMALLOC|__GFP_HARDWALL)
+ __GFP_NOMEMALLOC|__GFP_HARDWALL|__GFP_THISNODE)
/* This equals 0, but use constants in case they ever change */
#define GFP_NOWAIT (GFP_ATOMIC & ~__GFP_HIGH)
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-08-08 17:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-08 16:33 Christoph Lameter
2006-08-08 16:34 ` [2/3] sys_move_pages: Do not fall back to other nodes Christoph Lameter
2006-08-08 16:37 ` [3/3] Guarantee that the uncached allocator gets pages on the correct node Christoph Lameter
2006-08-08 16:56 ` [1/3] Add __GFP_THISNODE to avoid fallback to other nodes and ignore cpuset/memory policy restrictions Andy Whitcroft
2006-08-08 17:01 ` Christoph Lameter
2006-08-08 16:59 ` Mel Gorman
2006-08-08 17:03 ` Christoph Lameter
2006-08-08 17:16 ` Mel Gorman
2006-08-08 17:51 ` Christoph Lameter [this message]
2006-08-08 17:47 ` Paul Jackson
2006-08-08 17:59 ` Christoph Lameter
2006-08-08 18:18 ` Paul Jackson
2006-08-08 18:49 ` Christoph Lameter
2006-08-08 20:35 ` Paul Jackson
2006-08-09 9:33 ` Mel Gorman
2006-08-09 1:34 ` KAMEZAWA Hiroyuki
2006-08-09 2:00 ` Christoph Lameter
2006-08-10 19:41 ` Andrew Morton
2006-08-11 3:16 ` Christoph Lameter
2006-08-11 18:08 ` Andrew Morton
2006-08-11 18:15 ` Christoph Lameter
2006-08-11 18:42 ` Andrew Morton
2006-08-11 18:51 ` Christoph Lameter
2006-08-11 19:15 ` Andrew Morton
2006-08-11 19:16 ` Christoph Lameter
2006-08-11 19:41 ` Dave McCracken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0608081049040.28259@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=jes@sgi.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox