From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 7 Aug 2006 16:25:34 +0100 (BST) From: Hugh Dickins Subject: Re: [patch][rfc] possible lock_page fix for Andrea's nopage vs invalidate race? In-Reply-To: <44D75526.4050108@yahoo.com.au> Message-ID: References: <44CF3CB7.7030009@yahoo.com.au> <44D74B98.3030305@yahoo.com.au> <44D75526.4050108@yahoo.com.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: Andrea Arcangeli , Andrew Morton , David Howells , Linux Memory Management List-ID: On Tue, 8 Aug 2006, Nick Piggin wrote: > Nick Piggin wrote: > > > > Generic pagecache doesn't have an mmap method, which is where > > I stopped looking. I guess you could add the |= to filemap_nopage, > > but that's much uglier. You can't |= vm_flags in nopage, mmap_sem isn't exclusive there. But what's the matter with generic_file_mmap? > Hmm, I guess adding a new mmap method solely to set that flag > would actually be cleaner. And it would allow any filesystems > that override .nopage bug end up calling filemap_nopage could > equivalently override their mmap but still call filemap_mmap. Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org