From: Christoph Lameter <christoph@lameter.com>
To: Jeff Anderson-Lee <jonah@eecs.berkeley.edu>
Cc: 'Christoph Lameter' <clameter@sgi.com>,
'Peter Zijlstra' <a.p.zijlstra@chello.nl>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
'Hugh Dickins' <hugh@veritas.com>,
'Andrew Morton' <akpm@osdl.org>,
'David Howells' <dhowells@redhat.com>,
'Martin Bligh' <mbligh@google.com>,
'Nick Piggin' <npiggin@suse.de>,
'Linus Torvalds' <torvalds@osdl.org>
Subject: Re: [PATCH 1/3] mm: tracking shared dirty pages
Date: Thu, 25 May 2006 19:33:36 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0605251931380.15494@graphe.net> (raw)
In-Reply-To: <000001c6806c$19403760$ce2a2080@eecs.berkeley.edu>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 822 bytes --]
On Thu, 25 May 2006, Jeff Anderson-Lee wrote:
> Christoph Lameter wrote:
>
> > I am a bit confused about the need for Davids patch. set_page_dirty() is
> > already a notification that a page is to be dirtied. Why do we need it
> > twice? set_page_dirty could return an error code and the file system can
> > use the set_page_dirty() hook to get its notification. What we would need
> > to do is to make sure that set_page_dirty can sleep.
>
> set_page_dirty() is actually called fairly late in the game by
> zap_pte_range() and follow_page(). Thus, it is a notification that a page
> HAS BEEN dirtied and needs a writeback.
The tracking patch changes that behavior. set_page_dirty is called before
the write to the page occurs and so its similar to the new method
introduced by David's patch.
next prev parent reply other threads:[~2006-05-26 2:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-25 13:55 [PATCH 0/3] mm: tracking dirty pages -v5 Peter Zijlstra
2006-05-25 13:55 ` [PATCH -1/3] mm: page_mkwrite Peter Zijlstra
2006-05-25 13:55 ` [PATCH 1/3] mm: tracking shared dirty pages Peter Zijlstra
2006-05-25 16:21 ` Christoph Lameter
2006-05-25 17:00 ` Peter Zijlstra
2006-05-25 17:03 ` Christoph Lameter
2006-05-25 16:27 ` Christoph Lameter
2006-05-25 17:03 ` Peter Zijlstra
2006-05-25 17:06 ` Christoph Lameter
2006-05-26 2:28 ` Jeff Anderson-Lee
2006-05-26 2:33 ` Christoph Lameter [this message]
2006-05-26 14:33 ` David Howells
2006-05-26 15:39 ` Christoph Lameter
2006-05-30 8:00 ` David Howells
2006-05-30 15:38 ` Christoph Lameter
2006-05-30 16:26 ` David Howells
2006-05-30 17:02 ` Christoph Lameter
2006-05-30 17:25 ` Hugh Dickins
2006-05-30 17:30 ` Christoph Lameter
2006-05-30 17:41 ` Hugh Dickins
2006-05-30 17:56 ` David Howells
2006-05-30 20:21 ` Christoph Lameter
2006-05-25 13:56 ` [PATCH 2/3] mm: balance " Peter Zijlstra
2006-05-25 13:56 ` [PATCH 3/3] mm: msync cleanup Peter Zijlstra
2006-06-06 20:06 ` [PATCH 0/3] mm: tracking dirty pages -v5 Hugh Dickins
2006-06-07 18:08 ` Peter Zijlstra
2006-06-08 12:44 ` [PATCH] mm: tracking dirty pages -v6 Peter Zijlstra
2006-06-08 13:02 ` Peter Zijlstra
2006-06-08 16:53 ` Christoph Lameter
2006-06-08 20:10 ` Nate Diller
2006-06-08 20:20 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0605251931380.15494@graphe.net \
--to=christoph@lameter.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=dhowells@redhat.com \
--cc=hugh@veritas.com \
--cc=jonah@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mbligh@google.com \
--cc=npiggin@suse.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox