From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 25 May 2006 09:21:07 -0700 (PDT) From: Christoph Lameter Subject: Re: [PATCH 1/3] mm: tracking shared dirty pages In-Reply-To: <20060525135555.20941.36612.sendpatchset@lappy> Message-ID: References: <20060525135534.20941.91650.sendpatchset@lappy> <20060525135555.20941.36612.sendpatchset@lappy> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Peter Zijlstra Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Andrew Morton , David Howells , Christoph Lameter , Martin Bligh , Nick Piggin , Linus Torvalds List-ID: On Thu, 25 May 2006, Peter Zijlstra wrote: > @@ -1446,12 +1447,13 @@ static int do_wp_page(struct mm_struct * > > - if (unlikely(vma->vm_flags & VM_SHARED)) { > + if (vma->vm_flags & VM_SHARED) { You add this unlikely later again it seems. Why remove in the first place? > +static int page_mkclean_one(struct page *page, struct vm_area_struct *vma) > + entry = pte_mkclean(pte_wrprotect(*pte)); > + ptep_establish(vma, address, pte, entry); > + update_mmu_cache(vma, address, entry); You only changed protections on an estisting pte and ptep_establish already flushed the tlb. No need to call update_mmu_cache. See how change_protection() in mm/mprotect.c does it. > + lazy_mmu_prot_update(entry); Needed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org