From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 16 May 2006 08:58:11 -0700 (PDT) From: Christoph Lameter Subject: Re: [PATCH] mm: cleanup swap unused warning In-Reply-To: <200605162055.36957.kernel@kolivas.org> Message-ID: References: <200605102132.41217.kernel@kolivas.org> <200605162055.36957.kernel@kolivas.org> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-1700579579-186910767-1147795091=:6065" Sender: owner-linux-mm@kvack.org Return-Path: To: Con Kolivas Cc: linux list , linux-mm@kvack.org, Andrew Morton List-ID: ---1700579579-186910767-1147795091=:6065 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE On Tue, 16 May 2006, Con Kolivas wrote: > On Thursday 11 May 2006 09:04, Christoph Lameter wrote: > > On Wed, 10 May 2006, Con Kolivas wrote: > > > Are there any users of swp_entry_t when CONFIG_SWAP is not defined? > > > > Yes, a migration entry is a form of swap entry. >=20 > mm/vmscan.c: In function =FF=FFremove_mapping=FF=FF: > mm/vmscan.c:387: warning: unused variable =FF=FFswap=FF=FF >=20 > Ok so if we fix it by making swp_entry_t __attribute__((__unused__) we br= eak=20 > swap migration code? This will generally break page migration in mm. =20 > If we make swap_free() an empty static inline function then gcc compiles = in=20 > the variable needlessly and we won't know it. PageSwapCache() returns false if CONFIG_SWAP is not set and therefore no=20 code is generated. ---1700579579-186910767-1147795091=:6065-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org