From: Christoph Lameter <clameter@sgi.com>
To: Con Kolivas <kernel@kolivas.org>
Cc: linux list <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] mm: cleanup swap unused warning
Date: Tue, 16 May 2006 08:58:11 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0605160853330.6065@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <200605162055.36957.kernel@kolivas.org>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 775 bytes --]
On Tue, 16 May 2006, Con Kolivas wrote:
> On Thursday 11 May 2006 09:04, Christoph Lameter wrote:
> > On Wed, 10 May 2006, Con Kolivas wrote:
> > > Are there any users of swp_entry_t when CONFIG_SWAP is not defined?
> >
> > Yes, a migration entry is a form of swap entry.
>
> mm/vmscan.c: In function ÿÿremove_mappingÿÿ:
> mm/vmscan.c:387: warning: unused variable ÿÿswapÿÿ
>
> Ok so if we fix it by making swp_entry_t __attribute__((__unused__) we break
> swap migration code?
This will generally break page migration in mm.
> If we make swap_free() an empty static inline function then gcc compiles in
> the variable needlessly and we won't know it.
PageSwapCache() returns false if CONFIG_SWAP is not set and therefore no
code is generated.
next prev parent reply other threads:[~2006-05-16 15:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 11:32 Con Kolivas
2006-05-10 11:38 ` Andrew Morton
2006-05-10 11:46 ` Con Kolivas
2006-05-10 11:56 ` Con Kolivas
2006-05-10 18:20 ` Daniel Walker
2006-05-10 11:42 ` Pekka Enberg
2006-05-10 23:04 ` Christoph Lameter
2006-05-16 10:55 ` Con Kolivas
2006-05-16 13:14 ` Con Kolivas
2006-05-16 16:00 ` Christoph Lameter
2006-05-17 6:27 ` [PATCH][respin] " Con Kolivas
2006-05-16 15:58 ` Christoph Lameter [this message]
2006-05-16 11:24 ` [PATCH] " Roman Zippel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0605160853330.6065@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@osdl.org \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox