From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 8 May 2006 13:45:01 +0100 (BST) From: Hugh Dickins Subject: Re: [PATCH] fix can_share_swap_page() when !CONFIG_SWAP In-Reply-To: <445ED495.3020401@yahoo.com.au> Message-ID: References: <445ED495.3020401@yahoo.com.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: Hua Zhong , linux-kernel@vger.kernel.org, akpm@osdl.org, linux-mm@kvack.org List-ID: On Mon, 8 May 2006, Nick Piggin wrote: > Hua Zhong wrote: > > > >I'm not sure if it's the best fix. Maybe we should rename > >can_share_swap_page() and move it out of swapfile.c. Comments? > > Looks like a good patch, nice catch. You should run it past Hugh but tend to > agree it would be nice to reuse the out of line can_share_swap_page, which > would fold beautifully with PageSwapCache a constant 0. True; but I think Hua's patch is good as is for now, to fix that inefficiency. I do agree (as you know) that there's scope for cleanup there, and that that function is badly named; but I'm still unprepared to embark on the cleanup, so let's just get the fix in. Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org