From: Hugh Dickins <hugh@veritas.com>
To: Zoltan Menyhart <Zoltan.Menyhart@bull.net>
Cc: linux-mm@kvack.org, Zoltan.Menyhart@free.fr
Subject: Re: Any reason for passing "tlb" to "free_pgtables()" by address?
Date: Fri, 5 May 2006 13:41:12 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.64.0605051337520.6945@blonde.wat.veritas.com> (raw)
In-Reply-To: <445B2EBD.4020803@bull.net>
On Fri, 5 May 2006, Zoltan Menyhart wrote:
> Apparently, there is no reason for passing "tlb" to "free_pgtables()"
> by address, because there is no need for re-scheduling inside this
> function => no other "mmu_gather" can / will be used.
You're right. Well, actually, it's been shown that there _is_ a need
for rescheduling inside that function (high latency), but we've not
yet settled on the right way to go about that - mmu_gathering needs
overhaul to avoid disabling preemption, something both Nick and I
have worked on intermittently.
Personally I'd prefer not to make your change right now - it seems
a shame to make that cosmetic change without addressing the real
latency issue; but I've no strong feeling against your patch.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-05-05 12:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-05 10:53 Zoltan Menyhart
2006-05-05 12:41 ` Hugh Dickins [this message]
2006-05-08 21:50 ` Zoltan Menyhart
2006-05-09 1:40 ` Nick Piggin
2006-05-09 11:23 ` Hugh Dickins
2006-05-09 19:30 ` Zoltan Menyhart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0605051337520.6945@blonde.wat.veritas.com \
--to=hugh@veritas.com \
--cc=Zoltan.Menyhart@bull.net \
--cc=Zoltan.Menyhart@free.fr \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox