From: Christoph Lameter <clameter@sgi.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: akpm@osdl.org, linux-mm@kvack.org, hugh@veritas.com,
lee.schermerhorn@hp.com
Subject: Re: [PATCH 4/7] page migration: Drop nr_refs parameter
Date: Fri, 28 Apr 2006 06:57:28 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.64.0604280656500.32052@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20060428163033.4fa4863a.kamezawa.hiroyu@jp.fujitsu.com>
On Fri, 28 Apr 2006, KAMEZAWA Hiroyuki wrote:
> Then, could you add this comment to migrate_page_remove_references
> (renamed as migrate_page_move_mapping) ?
Signed-off-by: Christoph Lameter <clameter@sgi.com>
Index: linux-2.6.17-rc2-mm1/mm/migrate.c
===================================================================
--- linux-2.6.17-rc2-mm1.orig/mm/migrate.c 2006-04-27 23:39:11.853319378 -0700
+++ linux-2.6.17-rc2-mm1/mm/migrate.c 2006-04-28 06:56:36.856624280 -0700
@@ -248,6 +248,11 @@
/*
* Remove or replace the page in the mapping
+ *
+ * The number of remaining references must be:
+ * 1 for anonymous pages without a mapping
+ * 2 for pages with a mapping
+ * 3 for pages with a mapping and PagePrivate set.
*/
static int migrate_page_move_mapping(struct address_space *mapping,
struct page *newpage, struct page *page)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2006-04-28 13:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-28 6:03 [PATCH 1/7] page migration: Reorder functions in migrate.c Christoph Lameter
2006-04-28 6:03 ` [PATCH 2/7] page migration: Remove unnecessarily exported functions Christoph Lameter
2006-04-28 6:03 ` [PATCH 3/7] page migration: Change handling of address spaces Christoph Lameter
2006-04-28 6:03 ` [PATCH 4/7] page migration: Drop nr_refs parameter Christoph Lameter
2006-04-28 7:30 ` KAMEZAWA Hiroyuki
2006-04-28 13:57 ` Christoph Lameter [this message]
2006-04-28 6:03 ` [PATCH 5/7] page migration: synchronize from and to lists Christoph Lameter
2006-04-28 7:46 ` KAMEZAWA Hiroyuki
2006-04-28 15:31 ` Christoph Lameter
2006-04-29 0:27 ` KAMEZAWA Hiroyuki
2006-04-29 0:33 ` Christoph Lameter
2006-04-29 0:44 ` KAMEZAWA Hiroyuki
2006-04-29 0:46 ` Christoph Lameter
2006-04-28 6:03 ` [PATCH 6/7] page migration: Extract try_to_unmap Christoph Lameter
2006-04-28 6:03 ` [PATCH 7/7] page migration: Add new fallback function Christoph Lameter
2006-04-28 6:42 ` Christoph Lameter
2006-04-28 22:08 ` [PATCH 1/7] page migration: Reorder functions in migrate.c Andrew Morton
2006-04-28 23:01 ` Christoph Lameter
2006-04-28 23:18 ` Andrew Morton
2006-04-29 0:14 ` Christoph Lameter
2006-04-29 0:36 ` Andrew Morton
2006-04-29 0:46 ` Christoph Lameter
2006-04-29 2:27 ` Andrew Morton
2006-04-29 2:48 ` Christoph Lameter
2006-04-29 0:54 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0604280656500.32052@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox