From: Christoph Lameter <clameter@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-mm@kvack.org
Subject: Re: drain_node_pages: interrupt latency reduction / optimization
Date: Fri, 10 Mar 2006 16:33:06 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0603101629100.32555@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <20060310162826.5f7a50e4.akpm@osdl.org>
> > - pset = zone_pcp(zone, smp_processor_id());
> > + pset = zone_pcp(zone, raw_smp_processor_id());
> hm. That replaces a runtime check with a comment. If someone comes along
> and reuses this function wrongly they'll have a nasty subtle bug.
>
> IOW: it might be best to keep the smp_processor_id() check in there.
Ahh. The DEBUG_PREEMPT is much more intelligent now and checks for this in
the right way. I agree leave as is.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2006-03-11 0:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-10 20:59 Christoph Lameter
2006-03-11 0:05 ` Andrew Morton
2006-03-11 0:15 ` Christoph Lameter
2006-03-11 0:28 ` Andrew Morton
2006-03-11 0:33 ` Christoph Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0603101629100.32555@schroedinger.engr.sgi.com \
--to=clameter@sgi.com \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox