From: Christoph Lameter <clameter@engr.sgi.com>
To: Andi Kleen <ak@suse.de>
Cc: steiner@sgi.com, linux-mm@kvack.org, alokk@calsoftinc.com
Subject: Re: [RFC] Make the slab allocator observe NUMA policies
Date: Fri, 11 Nov 2005 09:40:52 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.62.0511110934110.20360@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <200511110406.24838.ak@suse.de>
On Fri, 11 Nov 2005, Andi Kleen wrote:
> > The following patch adds NUMA memory policy support. This means that the
> > slab entries (and therefore also the pages containing them) will be
> > allocated according to memory policy.
>
> You're adding a check and potential cache line miss to a really really hot
> path. I would prefer it to do the policy check only in the slower path of
> slab that gets memory from the backing page allocator. While not 100% exact
> this should be good enough for just spreading memory around during
> initialization. And I cannot really think of any other uses of this.
Hmm. Thats not easy to do since the slab allocator is managing the pages
in terms of the nodes where they are located. The whole thing is geared to
first inspect the lists for one node and then expand if no page is
available.
The cacheline already in use by the page allocator, the page allocator
will continually reference current->mempolicy. See alloc_page_vma and
alloc_pages_current. So its likely that the cacheline is already active
and the impact on the hot code patch is likely negligible.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-11-11 17:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-10 22:04 Christoph Lameter
2005-11-11 3:06 ` Andi Kleen
2005-11-11 17:40 ` Christoph Lameter [this message]
2005-11-13 11:22 ` Andi Kleen
2005-11-14 18:05 ` Christoph Lameter
2005-11-14 18:44 ` Andi Kleen
2005-11-14 19:08 ` Christoph Lameter
2005-11-15 3:34 ` Andi Kleen
2005-11-15 16:43 ` Christoph Lameter
2005-11-15 16:51 ` Andi Kleen
2005-11-15 16:55 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.62.0511110934110.20360@schroedinger.engr.sgi.com \
--to=clameter@engr.sgi.com \
--cc=ak@suse.de \
--cc=alokk@calsoftinc.com \
--cc=linux-mm@kvack.org \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox