From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 19 Sep 2005 11:22:04 -0700 (PDT) From: Christoph Lameter Subject: Re: [PATCH] Only process_die notifier in ia64_do_page_fault if KPROBES is configured. In-Reply-To: <20050830111830.GI26314@parcelfarce.linux.theplanet.co.uk> Message-ID: References: <200508262246.j7QMkEoT013490@linux.jf.intel.com> <200508270224.26423.ak@suse.de> <20050830001905.GA18279@linux.jf.intel.com> <20050830111830.GI26314@parcelfarce.linux.theplanet.co.uk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Matthew Wilcox Cc: Rusty Lynch , Andi Kleen , Rusty Lynch , linux-mm@kvack.org, prasanna@in.ibm.com, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, anil.s.keshavamurthy@intel.com List-ID: On Tue, 30 Aug 2005, Matthew Wilcox wrote: > On Mon, Aug 29, 2005 at 05:19:05PM -0700, Rusty Lynch wrote: > > So, assuming inlining the notifier_call_chain would address Christoph's > > conserns, is the following patch something like what you are sugesting? > > This would make all the kdebug.h::notify_die() calls use the inline version. > > I think we need something more like this ... > > include/linux/notifier.h: > +static inline int notifier_call_chain(struct notifier_block **n, > + unsigned long val, void *v) > +{ > + if (n) > + return __notifier_call_chain(n, val, v); > + return NOTIFY_DONE; > +} > kernel/sys.c: > -int notifier_call_chain(struct notifier_block **n, unsigned long val, void *v) > +int __notifier_call_chain(struct notifier_block **n, unsigned long val, void *v) > -EXPORT_SYMBOL(notifier_call_chain); > +EXPORT_SYMBOL(__notifier_call_chain); > > That way everyone gets both the quick test and the global size reduction. And then do #ifndef CONFIG_KPROBES #define ia64die_chain 0 #endif in include/asm-ia64/kdebug.h? Otherwise we still check a notifier chain that cannot ever be activated. But then the patch is essentially the same as the last one I proposed. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org