linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Lameter <clameter@engr.sgi.com>
To: linux-ia64@vger.kernel.org
Cc: linux-mm@kvack.org, prasanna@in.ibm.com
Subject: [PATCH] Only process_die notifier in ia64_do_page_fault if KPROBES is configured.
Date: Thu, 25 Aug 2005 13:14:26 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.62.0508251312010.7100@schroedinger.engr.sgi.com> (raw)

ia64_do_page_fault is a path critical for system performance. The code to call
notify_die() should not be compiled into that critical path if the system
is not configured to use KPROBES.

Signed-off-by: Christoph Lameter <clameter@sgi.com>

Index: linux-2.6.13-rc7/arch/ia64/mm/fault.c
===================================================================
--- linux-2.6.13-rc7.orig/arch/ia64/mm/fault.c	2005-08-23 20:39:14.000000000 -0700
+++ linux-2.6.13-rc7/arch/ia64/mm/fault.c	2005-08-25 13:04:57.000000000 -0700
@@ -103,12 +103,16 @@ ia64_do_page_fault (unsigned long addres
 		goto bad_area_no_up;
 #endif
 
+#ifdef CONFIG_KPROBES
 	/*
-	 * This is to handle the kprobes on user space access instructions
+	 * This is to handle the kprobes on user space access instructions.
+	 * This is a path criticial for system performance. So only
+	 * process this notifier if we are compiled with kprobes support.
 	 */
 	if (notify_die(DIE_PAGE_FAULT, "page fault", regs, code, TRAP_BRKPT,
 					SIGSEGV) == NOTIFY_STOP)
 		return;
+#endif
 
 	down_read(&mm->mmap_sem);
 
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2005-08-25 20:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-25 20:14 Christoph Lameter [this message]
2005-08-26 22:46 Rusty Lynch
2005-08-26 23:05 ` Christoph Lameter
2005-08-27  0:24   ` [PATCH] " Andi Kleen
2005-08-30  0:19     ` Rusty Lynch
2005-08-30  1:08       ` Andi Kleen
2005-08-30  3:28       ` Christoph Lameter
2005-08-30 11:18       ` Matthew Wilcox
2005-09-19 18:22         ` Christoph Lameter
2005-08-30 23:05 Luck, Tony
2005-08-30 23:38 ` Andi Kleen
2005-08-30 23:54   ` Christoph Lameter
2005-08-31  0:05     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.62.0508251312010.7100@schroedinger.engr.sgi.com \
    --to=clameter@engr.sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=prasanna@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox