From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 20 May 2005 12:23:52 -0700 (PDT) From: Christoph Lameter Subject: Re: NUMA aware slab allocator V3 In-Reply-To: <428E3497.3080406@us.ibm.com> Message-ID: References: <714210000.1116266915@flay> <200505161410.43382.jbarnes@virtuousgeek.org> <740100000.1116278461@flay> <1116289613.26955.14.camel@localhost> <428A800D.8050902@us.ibm.com> <428B7B16.10204@us.ibm.com> <428BB05B.6090704@us.ibm.com> <428E3497.3080406@us.ibm.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Matthew Dobson Cc: "Martin J. Bligh" , Andrew Morton , linux-mm , Linux Kernel Mailing List List-ID: On Fri, 20 May 2005, Matthew Dobson wrote: > Christoph, I'm getting the following errors building rc4-mm2 w/ GCC 2.95.4: Works fine here with gcc 2.95.4.ds15-22 but that is a debian gcc 2.95.4 patched up to work correctly. If you need to address the pathology in pristine gcc 2.95.4 by changing the source then declare the entry field with 0 members. Index: linux-2.6.12-rc4/mm/slab.c =================================================================== --- linux-2.6.12-rc4.orig/mm/slab.c 2005-05-19 21:29:45.000000000 +0000 +++ linux-2.6.12-rc4/mm/slab.c 2005-05-20 19:18:22.000000000 +0000 @@ -267,7 +267,7 @@ #ifdef CONFIG_NUMA spinlock_t lock; #endif - void *entry[]; + void *entry[0]; }; /* bootstrap: The caches do not work without cpuarrays anymore, gcc 2.95 can produce proper code for ppc64? > mm/slab.c:281: field `entry' has incomplete typemm/slab.c: In function > 'cache_alloc_refill': See patch above? > mm/slab.c:2497: warning: control reaches end of non-void function That is the end of cache_alloc_debug_check right? This is a void function in my source. > mm/slab.c: In function `kmem_cache_alloc': > mm/slab.c:2567: warning: `objp' might be used uninitialized in this function > mm/slab.c: In function `kmem_cache_alloc_node': > mm/slab.c:2567: warning: `objp' might be used uninitialized in this function > mm/slab.c: In function `__kmalloc': > mm/slab.c:2567: warning: `objp' might be used uninitialized in this function There is a branch there and the object is initialized in either branch. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org