From: Christoph Lameter <clameter@engr.sgi.com>
To: Michal Ludvig <michal@logix.cz>
Cc: Andrew Morton <akpm@osdl.org>, linux-mm@kvack.org
Subject: Re: [PATCH] fix for mm counters to macros conversion
Date: Mon, 16 May 2005 16:38:08 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.62.0505161637300.3702@schroedinger.engr.sgi.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0505162318310.9392@maxipes.logix.cz>
Ok. This is third or fourth time this patch was posted. I thought this
already went in?
On Mon, 16 May 2005, Michal Ludvig wrote:
> Hi,
>
> The patch of Christoph Lameter sent on March 15 contains this in
> mm/rmap.c:try_to_unmap_one() around line 590:
>
> - mm->rss--;
> + inc_mm_counter(mm, rss);
>
> I wonder if it was an intent to change dec to inc? In all other places the
> conversion conforms to the previous operation except for this one. Perhaps
> the following patch should be applied...
>
> Signed-off-by: Michal Ludvig <michal@logix.cz>
>
>
> Index: linux-2.6.12-rc4/mm/rmap.c
> ===================================================================
> --- linux-2.6.12-rc4.orig/mm/rmap.c 2005-05-07 17:20:31.000000000 +1200
> +++ linux-2.6.12-rc4/mm/rmap.c 2005-05-17 11:16:40.716223000 +1200
> @@ -586,7 +586,7 @@
> dec_mm_counter(mm, anon_rss);
> }
>
> - inc_mm_counter(mm, rss);
> + dec_mm_counter(mm, rss);
> page_remove_rmap(page);
> page_cache_release(page);
>
>
>
>
> Michal Ludvig
> --
> * Personal homepage - http://www.logix.cz/michal
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2005-05-16 23:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-16 23:34 Michal Ludvig
2005-05-16 23:38 ` Christoph Lameter [this message]
2005-05-16 23:53 ` Michal Ludvig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.62.0505161637300.3702@schroedinger.engr.sgi.com \
--to=clameter@engr.sgi.com \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
--cc=michal@logix.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox